public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Alexander Graf <agraf@suse.de>
To: kvm-ppc@vger.kernel.org
Cc: "kvm@vger.kernel.org mailing list" <kvm@vger.kernel.org>,
	Paul Mackerras <paulus@samba.org>
Subject: [PATCH 2/7] KVM: PPC: Book3S PR: Fix proto-VSID calculations
Date: Sun, 30 Jun 2013 03:38:43 +0200	[thread overview]
Message-ID: <1372556328-18617-3-git-send-email-agraf@suse.de> (raw)
In-Reply-To: <1372556328-18617-1-git-send-email-agraf@suse.de>

From: Paul Mackerras <paulus@samba.org>

This makes sure the calculation of the proto-VSIDs used by PR KVM
is done with 64-bit arithmetic.  Since vcpu3s->context_id[] is int,
when we do vcpu3s->context_id[0] << ESID_BITS the shift will be done
with 32-bit instructions, possibly leading to significant bits
getting lost, as the context id can be up to 524283 and ESID_BITS is
18.  To fix this we cast the context id to u64 before shifting.

Signed-off-by: Paul Mackerras <paulus@samba.org>
Signed-off-by: Alexander Graf <agraf@suse.de>
---
 arch/powerpc/kvm/book3s_64_mmu_host.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/powerpc/kvm/book3s_64_mmu_host.c b/arch/powerpc/kvm/book3s_64_mmu_host.c
index 3a9a1ac..2c6e7ee 100644
--- a/arch/powerpc/kvm/book3s_64_mmu_host.c
+++ b/arch/powerpc/kvm/book3s_64_mmu_host.c
@@ -325,9 +325,9 @@ int kvmppc_mmu_init(struct kvm_vcpu *vcpu)
 		return -1;
 	vcpu3s->context_id[0] = err;
 
-	vcpu3s->proto_vsid_max = ((vcpu3s->context_id[0] + 1)
+	vcpu3s->proto_vsid_max = ((u64)(vcpu3s->context_id[0] + 1)
 				  << ESID_BITS) - 1;
-	vcpu3s->proto_vsid_first = vcpu3s->context_id[0] << ESID_BITS;
+	vcpu3s->proto_vsid_first = (u64)vcpu3s->context_id[0] << ESID_BITS;
 	vcpu3s->proto_vsid_next = vcpu3s->proto_vsid_first;
 
 	kvmppc_mmu_hpte_init(vcpu);
-- 
1.8.1.4


  parent reply	other threads:[~2013-06-30  1:38 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-30  1:38 [PULL 0/7] ppc patch queue 2013-06-30 Alexander Graf
2013-06-30  1:38 ` [PATCH 1/7] KVM: PPC: Guard doorbell exception with CONFIG_PPC_DOORBELL Alexander Graf
2013-06-30  1:38 ` Alexander Graf [this message]
2013-06-30  1:38 ` [PATCH 3/7] KVM: PPC: Book3S PR: Fix invalidation of SLB entry 0 on guest entry Alexander Graf
2013-06-30  1:38 ` [PATCH 4/7] KVM: PPC: Book3S PR: Don't keep scanning HPTEG after we find a match Alexander Graf
2013-06-30  1:38 ` [PATCH 5/7] KVM: PPC: Book3S PR: Allow guest to use 1TB segments Alexander Graf
2013-06-30  1:38 ` [PATCH 6/7] KVM: PPC: Book3S PR: Invalidate SLB entries properly Alexander Graf
2013-06-30  1:38 ` [PATCH 7/7] KVM: PPC: Ignore PIR writes Alexander Graf
2013-06-30  1:59 ` [PULL 0/7] ppc patch queue 2013-06-30 Alexander Graf
2013-07-02  7:47 ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1372556328-18617-3-git-send-email-agraf@suse.de \
    --to=agraf@suse.de \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox