public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Alexander Graf <agraf@suse.de>
To: kvm-ppc@vger.kernel.org
Cc: "kvm@vger.kernel.org mailing list" <kvm@vger.kernel.org>
Subject: [PATCH 7/7] KVM: PPC: Ignore PIR writes
Date: Sun, 30 Jun 2013 03:38:48 +0200	[thread overview]
Message-ID: <1372556328-18617-8-git-send-email-agraf@suse.de> (raw)
In-Reply-To: <1372556328-18617-1-git-send-email-agraf@suse.de>

While technically it's legal to write to PIR and have the identifier changed,
we don't implement logic to do so because we simply expose vcpu_id to the guest.

So instead, let's ignore writes to PIR. This ensures that we don't inject faults
into the guest for something the guest is allowed to do. While at it, we cross
our fingers hoping that it also doesn't mind that we broke its PIR read values.

Signed-off-by: Alexander Graf <agraf@suse.de>
---
 arch/powerpc/kvm/emulate.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/powerpc/kvm/emulate.c b/arch/powerpc/kvm/emulate.c
index 631a265..2c52ada 100644
--- a/arch/powerpc/kvm/emulate.c
+++ b/arch/powerpc/kvm/emulate.c
@@ -169,6 +169,9 @@ static int kvmppc_emulate_mtspr(struct kvm_vcpu *vcpu, int sprn, int rs)
 		vcpu->arch.shared->sprg3 = spr_val;
 		break;
 
+	/* PIR can legally be written, but we ignore it */
+	case SPRN_PIR: break;
+
 	default:
 		emulated = kvmppc_core_emulate_mtspr(vcpu, sprn,
 						     spr_val);
-- 
1.8.1.4

  parent reply	other threads:[~2013-06-30  1:38 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-30  1:38 [PULL 0/7] ppc patch queue 2013-06-30 Alexander Graf
2013-06-30  1:38 ` [PATCH 1/7] KVM: PPC: Guard doorbell exception with CONFIG_PPC_DOORBELL Alexander Graf
2013-06-30  1:38 ` [PATCH 2/7] KVM: PPC: Book3S PR: Fix proto-VSID calculations Alexander Graf
2013-06-30  1:38 ` [PATCH 3/7] KVM: PPC: Book3S PR: Fix invalidation of SLB entry 0 on guest entry Alexander Graf
2013-06-30  1:38 ` [PATCH 4/7] KVM: PPC: Book3S PR: Don't keep scanning HPTEG after we find a match Alexander Graf
2013-06-30  1:38 ` [PATCH 5/7] KVM: PPC: Book3S PR: Allow guest to use 1TB segments Alexander Graf
2013-06-30  1:38 ` [PATCH 6/7] KVM: PPC: Book3S PR: Invalidate SLB entries properly Alexander Graf
2013-06-30  1:38 ` Alexander Graf [this message]
2013-06-30  1:59 ` [PULL 0/7] ppc patch queue 2013-06-30 Alexander Graf
2013-07-02  7:47 ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1372556328-18617-8-git-send-email-agraf@suse.de \
    --to=agraf@suse.de \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox