From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Subject: Re: [PATCH 1/2] powerpc/booke64: Use common defines for AltiVec interrupts numbers Date: Mon, 1 Jul 2013 19:56:53 -0500 Message-ID: <1372726613.8183.104@snotra> References: <8F554F03-E6B0-4140-8830-D4FD6249CEF9@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; delsp=Yes; format=Flowed Content-Transfer-Encoding: 8BIT Cc: Mihai Caraman , , , To: Alexander Graf Return-path: In-Reply-To: <8F554F03-E6B0-4140-8830-D4FD6249CEF9@suse.de> (from agraf@suse.de on Mon Jul 1 19:18:21 2013) Content-Disposition: inline Sender: kvm-ppc-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 07/01/2013 07:18:21 PM, Alexander Graf wrote: > > On 01.07.2013, at 17:35, Mihai Caraman wrote: > > > On Book3E some SPE/FP/AltiVec interrupts share the same number. Use > > common defines to indentify these numbers. > > So why didn't this happen from the beginning? Ask Kumar. > Why the change? So we can remove this hack in kvm_asm.h: /* * TODO: Unify 32-bit and 64-bit kernel exception handlers to use same defines */ #define BOOKE_INTERRUPT_SPE_UNAVAIL BOOKE_INTERRUPT_SPE_ALTIVEC_UNAVAIL #define BOOKE_INTERRUPT_SPE_FP_DATA BOOKE_INTERRUPT_SPE_FP_DATA_ALTIVEC_ASSIST #define BOOKE_INTERRUPT_ALTIVEC_UNAVAIL BOOKE_INTERRUPT_SPE_ALTIVEC_UNAVAIL #define BOOKE_INTERRUPT_ALTIVEC_ASSIST \ BOOKE_INTERRUPT_SPE_FP_DATA_ALTIVEC_ASSIST It was added as a compilation fix, and it was less intrusive to temporarily fix it this way. I am curious why the above code wasn't removed at the end of this patchset. :-) -Scott