Re: [PATCH 2/2] KVM: PPC: Book3E: Add LRAT error exception handler

Scott Wood
2013-07-03T21:52:53Z

On 07/03/2013 04:42:40 PM, Alexander Graf wrote:
>
> On 03.07.2013, at 22:16, Scott Wood wrote:
>
> > On 07/03/2013 11:56:06 AM, Mihai Caraman wrote:
> >> With LRAT (Logical to Real Address Translation) error exception
> handler in kernel
> >> KVM needs to add the counterpart otherwise will break the build.
> >> Signed-off-by: Mihai Caraman <mihai.caraman@freescale.com>
> >> ---
> >> arch/powerpc/kvm/bookehv_interrupts.S | 2 ++
> >> 1 files changed, 2 insertions(+), 0 deletions(-)
> >
> > Please combine these two patches to avoid breaking bisectability.
>
> Why does the split break bisectability?

Same reason as the altivec build breakage from earlier. If we add a
new exception type but not a KVM handler for it, the kernel won't link.

-Scott