public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: Alexander Graf <agraf@suse.de>
Cc: Bhushan Bharat-R65777 <R65777@freescale.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"kvm-ppc@vger.kernel.org" <kvm-ppc@vger.kernel.org>,
	Wood Scott-B07421 <B07421@freescale.com>,
	Yoder Stuart-B08248 <B08248@freescale.com>
Subject: Re: [PATCH 5/5] powerpc: using reset hcall when kvm,has-reset
Date: Tue, 16 Jul 2013 18:26:40 -0500	[thread overview]
Message-ID: <1374017200.8183.346@snotra> (raw)
In-Reply-To: <467C55E3-C05F-4B42-BC6D-00F7719E3D72@suse.de> (from agraf@suse.de on Tue Jul 16 18:21:51 2013)

On 07/16/2013 06:21:51 PM, Alexander Graf wrote:
> 
> On 16.07.2013, at 00:23, Scott Wood wrote:
> 
> > Still, I'm not sure what sort of error you're thinking of.  If the  
> guest didn't support the hcall mechanism we would have returned from  
> the function by that point.  In fact, seeing kvm,has-reset on a  
> different hypervisor ought to mean that that hypervisor is emulating  
> KVM in this particular respect.
> 
> Imagine we're running on KVM with this reset hcall support. Now if  
> the guest has CONFIG_EPAPR_PARAVIRT enabled but CONFIG_KVM_GUEST  
> disabled, we would patch the callback, but kvm_hypercall0() would be  
> implemented as a nop.

Ugh -- that should be renamed epapr_hypercall and moved to  
epapr_paravirt.c.

-Scott

  reply	other threads:[~2013-07-16 23:26 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-15 11:11 [PATCH 0/5] powerpc: implement reset/shutdown hcalls Bharat Bhushan
2013-07-15 11:11 ` [PATCH 1/5] powerpc: define ePAPR hcall exit interface Bharat Bhushan
2013-07-15 11:21   ` Alexander Graf
2013-07-15 11:32     ` Bhushan Bharat-R65777
2013-07-15 11:11 ` [PATCH 2/5] booke: exit to guest userspace for unimplemented hcalls in kvm Bharat Bhushan
2013-07-15 11:31   ` Alexander Graf
2013-07-15 11:38     ` Bhushan Bharat-R65777
2013-07-15 11:46       ` Alexander Graf
2013-07-15 14:50         ` Bhushan Bharat-R65777
2013-07-15 14:56           ` Alexander Graf
2013-07-15 15:13             ` Bhushan Bharat-R65777
2013-07-15 15:29               ` Alexander Graf
2013-07-15 15:35                 ` Bhushan Bharat-R65777
2013-07-15 15:38                   ` Alexander Graf
2013-07-15 18:07   ` Scott Wood
2013-07-16  4:46     ` Bhushan Bharat-R65777
2013-07-15 11:11 ` [PATCH 3/5] booke: define reset and shutdown hcalls Bharat Bhushan
2013-07-15 11:30   ` Gleb Natapov
2013-07-15 11:44     ` Alexander Graf
2013-07-15 12:15       ` Gleb Natapov
2013-07-15 12:21         ` Alexander Graf
2013-07-15 12:24           ` Gleb Natapov
2013-07-15 12:26             ` Alexander Graf
2013-07-15 12:31               ` Gleb Natapov
2013-07-15 18:17     ` Scott Wood
2013-07-16  6:35       ` Gleb Natapov
2013-07-16 23:04         ` Scott Wood
2013-07-17 11:00           ` Gleb Natapov
2013-07-17 12:19             ` Alexander Graf
2013-07-17 15:19               ` Yoder Stuart-B08248
2013-07-17 15:21                 ` Alexander Graf
2013-07-17 15:36                   ` Yoder Stuart-B08248
2013-07-17 15:41                     ` Alexander Graf
2013-07-17 15:47                       ` Bhushan Bharat-R65777
2013-07-17 15:52                         ` Alexander Graf
2013-07-17 15:59                           ` Bhushan Bharat-R65777
2013-07-17 16:04                             ` Alexander Graf
2013-07-17 16:21                               ` Bhushan Bharat-R65777
2013-07-17 16:23                                 ` Alexander Graf
2013-07-17 16:59                               ` Scott Wood
2013-07-17 17:05                                 ` Alexander Graf
2013-07-17 17:09                                   ` Scott Wood
2013-07-15 11:11 ` [PATCH 4/5] powerpc: Resolve KVM_HC_FEATURES compilation dependeny Bharat Bhushan
2013-07-15 11:46   ` Alexander Graf
2013-07-15 11:11 ` [PATCH 5/5] powerpc: using reset hcall when kvm,has-reset Bharat Bhushan
2013-07-15 11:50   ` Alexander Graf
2013-07-15 15:05     ` Bhushan Bharat-R65777
2013-07-15 15:09       ` Alexander Graf
2013-07-15 15:16         ` Bhushan Bharat-R65777
2013-07-15 18:21           ` Scott Wood
2013-07-15 20:28             ` Alexander Graf
2013-07-15 20:52               ` Scott Wood
2013-07-15 20:55                 ` Alexander Graf
2013-07-15 22:23                   ` Scott Wood
2013-07-16 23:21                     ` Alexander Graf
2013-07-16 23:26                       ` Scott Wood [this message]
2013-07-16 23:37                         ` Scott Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1374017200.8183.346@snotra \
    --to=scottwood@freescale.com \
    --cc=B07421@freescale.com \
    --cc=B08248@freescale.com \
    --cc=R65777@freescale.com \
    --cc=agraf@suse.de \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox