Re: [PATCH 5/5] powerpc: using reset hcall when kvm,has-reset

Scott Wood
2013-07-16T23:26:40Z

On 07/16/2013 06:21:51 PM, Alexander Graf wrote:
>
> On 16.07.2013, at 00:23, Scott Wood wrote:
>
> > Still, I'm not sure what sort of error you're thinking of. If the
> guest didn't support the hcall mechanism we would have returned from
> the function by that point. In fact, seeing kvm,has-reset on a
> different hypervisor ought to mean that that hypervisor is emulating
> KVM in this particular respect.
>
> Imagine we're running on KVM with this reset hcall support. Now if
> the guest has CONFIG_EPAPR_PARAVIRT enabled but CONFIG_KVM_GUEST
> disabled, we would patch the callback, but kvm_hypercall0() would be
> implemented as a nop.

Ugh -- that should be renamed epapr_hypercall and moved to
epapr_paravirt.c.

-Scott