From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Subject: Re: [PATCH v8] KVM: PPC: reserve a capability and ioctl numbers for realmode VFIO Date: Wed, 28 Aug 2013 11:26:31 +1000 Message-ID: <1377653191.3819.146.camel@pasglop> References: <1376552966-8529-1-git-send-email-aik@ozlabs.ru> <20130827075600.GE22899@redhat.com> <521C666A.3020508@ozlabs.ru> <20130827105832.GH22899@redhat.com> <521D4977.7060803@ozlabs.ru> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Gleb Natapov , kvm@vger.kernel.org, Alexander Graf , linux-kernel@vger.kernel.org, Paul Mackerras , linuxppc-dev@lists.ozlabs.org, David Gibson To: Alexey Kardashevskiy Return-path: In-Reply-To: <521D4977.7060803@ozlabs.ru> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Sender: "Linuxppc-dev" List-Id: kvm.vger.kernel.org On Wed, 2013-08-28 at 10:51 +1000, Alexey Kardashevskiy wrote: > The ioctl I made up is basically a copy of KVM_CREATE_SPAPR_TCE which does > the same thing for emulated devices and it is there for quite a while but > it is not really extensible. And these two ioctls share some bits of code. > Now we will have 2 pieces of code which do almost the same thing but in a > different way. Kinda sucks :( Right. Thus the question, Gleb, we can either: - Keep Alexey patch as-is allowing us to *finally* merge that stuff that's been around for monthes - Convert *both* existing TCE objects to the new KVM_CREATE_DEVICE, and have some backward compat code for the old one. I don't think it makes sense to have the "emulated TCE" and "IOMMU TCE" objects use a fundamentally different API and infrastructure. > >> So my stuff is not going to upstream again. Heh. Ok. I'll implement it. > >> > > Thanks! Should I keep KVM_CAP_SPAPR_MULTITCE capability patch or can I > > drop it for now? > > Please keep it, it is unrelated to the IOMMU-VFIO thing.