From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Subject: Re: [PATCH 2/3] hwrng: Add a driver for the hwrng found in power7+ systems Date: Thu, 26 Sep 2013 18:01:27 +1000 Message-ID: <1380182487.28561.22.camel@pasglop> References: <1380177066-3835-1-git-send-email-michael@ellerman.id.au> <1380177066-3835-2-git-send-email-michael@ellerman.id.au> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, Paul Mackerras , gleb@redhat.com, pbonzini@redhat.com, agraf@suse.de, mpm@selenic.com, herbert@gondor.hengli.com.au, linuxppc-dev@ozlabs.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, tytso@mit.edu To: Michael Ellerman Return-path: In-Reply-To: <1380177066-3835-2-git-send-email-michael@ellerman.id.au> Sender: kvm-ppc-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Thu, 2013-09-26 at 16:31 +1000, Michael Ellerman wrote: > + pr_info("registered powernv hwrng.\n"); First letter of a line should get a capital :-) Also since it's per-device, at least indicate the OF path or the chip number or something ... Cheers, Ben.