From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Subject: Re: RFC: (re-)binding the VFIO platform driver to a platform device Date: Wed, 2 Oct 2013 15:19:37 -0500 Message-ID: <1380745177.12932.81.camel@snotra.buserror.net> References: <20131001133831.6e46e8e00e09d5d9079fde57@linaro.org> <20131001200054.GA27330@kroah.com> <20131001170244.ff4fb81d9a7a09598c4c6247@linaro.org> <20131002015355.GD63102@lvm> <1380681356.14271.57.camel@ul30vt.home> <20131002151413.GG63102@lvm> <9F6FE96B71CF29479FF1CDC8046E15036D405D@039-SN1MPN1-003.039d.mgd.msft.net> <1380738758.12932.43.camel@snotra.buserror.net> <20131002184330.GC5108@cbox> <20131002150415.458f40ac97cd6ea9de9c590d@linaro.org> <20131002201307.GA3029@lvm> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Kim Phillips , , , , , , , , , , , , To: Christoffer Dall Return-path: In-Reply-To: <20131002201307.GA3029@lvm> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Wed, 2013-10-02 at 21:13 +0100, Christoffer Dall wrote: > On Wed, Oct 02, 2013 at 03:04:15PM -0500, Kim Phillips wrote: > > On Wed, 2 Oct 2013 11:43:30 -0700 > > Christoffer Dall wrote: > > > > > On Wed, Oct 02, 2013 at 01:32:38PM -0500, Scott Wood wrote: > > > > What's wrong with a non-vfio-specific flag that a driver can set, that > > > > indicates that the driver is willing to try to bind to any device on the > > > > bus if explicitly requested via the existing sysfs bind mechanism? > > > > > > > It sounds more hackish to me to invent some 'generic' flag to solve a > > > very specific case. What you're suggesting would let users specify that > > > a serial driver should handle a NIC hardware, no? That sounds much much > > > worse to me. > > > > I thought that was the nature of VFIO drivers...it's a 'meta-' driver, > > used for enabling userspace drivers at large. > > > Yes, vfio is a meta driver, therefore it needs to be able to do > something special, but the generic driver/device/bus matching framework > doesn't need an extra generic feature allowing you to bind driver X to > device Y for all combinations of X and Y depending on some flag... Not all combinations of X and Y. Only instances of X that advertise that this is OK. > Someone please correct me if there are more use cases for this and this > is in fact worth a generic solution. Note that the wildcard match that I suggested in the e-mail I just sent would likely be implemented by the bus match code -- not by generic driver model code. It would still be less intrusive than implementing a dynamic match mechanism for each bus type (and for device tree, ACPI, etc in the case of platform bus). -Scott