From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alex Williamson <alex.williamson@redhat.com>
Subject: Re: [PULL 3/6] vfio-pci: Lazy PCI option ROM loading
Date: Thu, 03 Oct 2013 13:11:34 -0600
Message-ID: <1380827494.2673.57.camel@ul30vt.home>
References: <20131003153601.26487.70022.stgit@bling.home>
	<20131003153902.26487.60908.stgit@bling.home>
	<524DBB7C.2080804@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Cc: aik@ozlabs.ru, qemu-devel@nongnu.org, anthony@codemonkey.ws,
	kvm@vger.kernel.org
To: Paolo Bonzini <pbonzini@redhat.com>
Return-path: <qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org>
In-Reply-To: <524DBB7C.2080804@redhat.com>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org
Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org
List-Id: kvm.vger.kernel.org

On Thu, 2013-10-03 at 20:46 +0200, Paolo Bonzini wrote:
> Il 03/10/2013 17:39, Alex Williamson ha scritto:
> > +static const MemoryRegionOps vfio_rom_ops = {
> > +    .read = vfio_rom_read,
> > +    .endianness = DEVICE_LITTLE_ENDIAN,
> > +};
> > +
> 
> I think you need to define a write callback too (unless you're sure for
> some other reason that the area will never be loaded).

Ok, I was under the impression that the memory API would handle lack of
an accessor as not supporting that access.  I can add a follow on patch
to make a dummy write function if my assumption isn't true.  Thanks,

Alex