From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pawel Moll Subject: Re: [PATCH 3/3] virtio: mmio: access configuration space as little-endian Date: Mon, 14 Oct 2013 09:44:44 +0100 Message-ID: <1381740284.3247.4.camel@hornet> References: <1381502171-8187-1-git-send-email-marc.zyngier@arm.com> <1381502171-8187-4-git-send-email-marc.zyngier@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: "linux-arm-kernel@lists.infradead.org" , "kvmarm@lists.cs.columbia.edu" , "kvm@vger.kernel.org" , Rusty Russell , "Michael S. Tsirkin" To: Marc Zyngier Return-path: Received: from service87.mimecast.com ([91.220.42.44]:58527 "EHLO service87.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751067Ab3JNIot convert rfc822-to-8bit (ORCPT ); Mon, 14 Oct 2013 04:44:49 -0400 In-Reply-To: <1381502171-8187-4-git-send-email-marc.zyngier@arm.com> Sender: kvm-owner@vger.kernel.org List-ID: On Fri, 2013-10-11 at 15:36 +0100, Marc Zyngier wrote: > virtio_mmio defines the config space to be little-endian.=20 This is not exactly true. The configuration *registers* (magic value, queue selector etc.) are always LE, yes. The configuration *space* (the free-form stuff starting at 0x100) is still guest-endian. The spec-in-works makes everything LE and the driver will most likely get accessors for the config space. Rusty had a go at this a while ago: http://thread.gmane.org/gmane.linux.kernel.virtualization/19397 Pawe=C5=82