public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Alexander Graf <agraf@suse.de>
To: "\"" <kvm-ppc@vger.kernel.org>, " <kvm-ppc@vger.kernel.org>"@suse.de
Cc: "kvm@vger.kernel.org mailing list" <kvm@vger.kernel.org>
Subject: [PATCH 0/4] KVM: PPC: Book3S: PR: Fix with CONFIG_PREEMPT=y
Date: Fri, 29 Nov 2013 03:54:57 +0100	[thread overview]
Message-ID: <1385693701-27632-1-git-send-email-agraf@suse.de> (raw)

When we run book3s pr kvm with CONFIG_PREEMPT=y badness occurs.

The reason is that we don't expect interrups to occur in the exit
path until we hit the point where we enable interrupts (after the
svcpu sync).

However thanks to our manual interrupt replay logic we do get
preempted because the interrupt handler thinks we have interrupts
enabled.

While debugging this I also stumbled over a register clobbering
issue that this patch set also fixes.

I would consider all of these patches for 3.13 with CC on stable
once they're through review.


Alex

Alexander Graf (4):
  KVM: PPC: Book3S: PR: Don't clobber our exit handler id
  KVM: PPC: Book3S: PR: Export kvmppc_copy_to|from_svcpu
  KVM: PPC: Book3S: PR: Make svcpu -> vcpu store preempt savvy
  KVM: PPC: Book3S: PR: Enable interrupts earlier

 arch/powerpc/include/asm/kvm_book3s.h     |  4 ++++
 arch/powerpc/include/asm/kvm_book3s_asm.h |  1 +
 arch/powerpc/kvm/book3s_interrupts.S      | 21 ++++++++++++---------
 arch/powerpc/kvm/book3s_pr.c              | 22 ++++++++++++++++++++++
 arch/powerpc/kvm/book3s_rmhandlers.S      |  6 +-----
 5 files changed, 40 insertions(+), 14 deletions(-)

-- 
1.8.1.4

             reply	other threads:[~2013-11-29  2:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-29  2:54 Alexander Graf [this message]
2013-11-29  2:54 ` [PATCH 1/4] KVM: PPC: Book3S: PR: Don't clobber our exit handler id Alexander Graf
2013-11-30  7:20   ` Paul Mackerras
2013-11-30 12:38     ` Alexander Graf
2013-11-29  2:54 ` [PATCH 2/4] KVM: PPC: Book3S: PR: Export kvmppc_copy_to|from_svcpu Alexander Graf
2013-11-29  2:55 ` [PATCH 3/4] KVM: PPC: Book3S: PR: Make svcpu -> vcpu store preempt savvy Alexander Graf
2013-11-29  2:55 ` [PATCH 4/4] KVM: PPC: Book3S: PR: Enable interrupts earlier Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1385693701-27632-1-git-send-email-agraf@suse.de \
    --to=agraf@suse.de \
    --cc=" <kvm-ppc@vger.kernel.org>"@suse.de \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox