Re: [PATCH 16/17] arm: add useful headers from the linux kernel

Andrew Jones
2014-02-03T16:46:22Z

On Sat, Feb 01, 2014 at 06:29:05PM -0800, Christoffer Dall wrote:
> On Tue, Jan 21, 2014 at 05:22:02PM +0100, Andrew Jones wrote:
> > We're going to need PSR bit defines and pt_regs. We'll also need
> > pt_regs offsets in assembly code. This patch adapts the linux
> > kernel's ptrace.h and asm-offsets to this framework. Even though
> > lib/arm/asm-offsets.h is a generated file, we still commit it,
> > as it's unlikely to change. Also adapt cp15.h from the kernel,
> > since we'll need bit defines from there too.
> >
> > Signed-off-by: Andrew Jones <drjones@redhat.com>
> > ---
>
> [...]
>
> > +
> > +asm-offsets: scripts/arm/asm-offsets.flat
> > + $(QEMU) -device virtio-testdev -display none -serial stdio \
> > + -M virt -cpu $(PROCESSOR) \
> > + -kernel $^ > lib/arm/asm-offsets.h || true
>
> I still disagree with this requirement to have the correct version of
> qemu on the build machine.

Ah sorry, I forgot about this one. I'll steal more from the kernel
on the asm-offsets generation to improve this for v4.

>
> [...]
>
> -Christoffer