From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Subject: Re: [RFC PATCH 02/10] KVM: PPC: BOOK3S: PR: Emulate virtual timebase register Date: Thu, 30 Jan 2014 11:35:16 +1100 Message-ID: <1391042116.8524.84.camel@pasglop> References: <1390927455-3312-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <1390927455-3312-3-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <52E92EC6.2030607@suse.de> <1391036081.8524.80.camel@pasglop> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: "Aneesh Kumar K.V" , paulus@samba.org, linuxppc-dev@lists.ozlabs.org, kvm-ppc@vger.kernel.org, kvm@vger.kernel.org To: Alexander Graf Return-path: In-Reply-To: <1391036081.8524.80.camel@pasglop> Sender: kvm-ppc-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Thu, 2014-01-30 at 09:54 +1100, Benjamin Herrenschmidt wrote: > On Wed, 2014-01-29 at 17:39 +0100, Alexander Graf wrote: > > static inline mfvtb(unsigned long) > > { > > #ifdef CONFIG_PPC_BOOK3S_64 > > return mfspr(SPRN_VTB); > > #else > > BUG(); > > #endif > > } > > > > is a lot easier to read and get right. But reg.h is Ben's call. > > Agreed. I mean I agree with Alex, his version is nicer :-) Cheers, Ben.