From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Ellerman Subject: Re: powerpc/pseries: Use new defines when calling h_set_mode Date: Fri, 30 May 2014 18:56:47 +1000 Message-ID: <1401440207.29324.10.camel@concordia> References: <1401106626-13130-1-git-send-email-paulus@samba.org> <1401106626-13130-4-git-send-email-paulus@samba.org> <5385E620.5090703@suse.de> <1401342462.4116.4.camel@ale.ozlabs.ibm.com> <1401344549.4116.8.camel@ale.ozlabs.ibm.com> <1401349547.4116.19.camel@ale.ozlabs.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Alexander Graf , linuxppc-dev , Paul Mackerras , "kvm@vger.kernel.org" , "kvm-ppc@vger.kernel.org" To: Michael Neuling Return-path: In-Reply-To: <1401349547.4116.19.camel@ale.ozlabs.ibm.com> Sender: kvm-ppc-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Thu, 2014-05-29 at 17:45 +1000, Michael Neuling wrote: > > > +/* Values for 2nd argument to H_SET_MODE */ > > > +#define H_SET_MODE_RESOURCE_SET_CIABR 1 > > > +#define H_SET_MODE_RESOURCE_SET_DAWR 2 > > > +#define H_SET_MODE_RESOURCE_ADDR_TRANS_MODE 3 > > > +#define H_SET_MODE_RESOURCE_LE 4 > > > > Much better, but I think you want to make use of these in non-kvm code too, > > no? At least the LE one is definitely already implemented as call :) > > powerpc/pseries: Use new defines when calling h_set_mode > > Now that we define these in the KVM code, use these defines when we call > h_set_mode. No functional change. > > Signed-off-by: Michael Neuling > -- > This depends on the KVM h_set_mode patches. > > diff --git a/arch/powerpc/include/asm/plpar_wrappers.h b/arch/powerpc/include/asm/plpar_wrappers.h > index 12c32c5..67859ed 100644 > --- a/arch/powerpc/include/asm/plpar_wrappers.h > +++ b/arch/powerpc/include/asm/plpar_wrappers.h > @@ -273,7 +273,7 @@ static inline long plpar_set_mode(unsigned long mflags, unsigned long resource, > static inline long enable_reloc_on_exceptions(void) > { > /* mflags = 3: Exceptions at 0xC000000000004000 */ > - return plpar_set_mode(3, 3, 0, 0); > + return plpar_set_mode(3, H_SET_MODE_RESOURCE_ADDR_TRANS_MODE, 0, 0); > } Which header are these coming from, and why aren't we including it? And is it going to still build with CONFIG_KVM=n? cheers