Re: [RFC PATCH v6 02/20] iommu: add capability IOMMU_CAP_NOEXEC

Alex Williamson
2014-06-05T20:03:47Z

On Thu, 2014-06-05 at 19:03 +0200, Antonios Motakis wrote:
> Some IOMMUs accept an IOMMU_NOEXEC protection flag in addition to
> IOMMU_READ and IOMMU_WRITE. Expose this as an IOMMU capability.
>
> Signed-off-by: Antonios Motakis <a.motakis-lrHrjnjw1UfHK3s98zE1ajGjJy/sRE9J@public.gmane.org>
> ---
> include/linux/iommu.h | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/iommu.h b/include/linux/iommu.h
> index fc464d2..7e152fb 100644
> --- a/include/linux/iommu.h
> +++ b/include/linux/iommu.h
> @@ -57,8 +57,9 @@ struct iommu_domain {
> struct iommu_domain_geometry geometry;
> };
>
> -#define IOMMU_CAP_CACHE_COHERENCY 0x1
> -#define IOMMU_CAP_INTR_REMAP 0x2 /* isolates device intrs */
> +#define IOMMU_CAP_CACHE_COHERENCY (1 << 0)
> +#define IOMMU_CAP_INTR_REMAP (1 << 1) /* isolates device intrs */
> +#define IOMMU_CAP_NOEXEC (1 << 2) /* IOMMU_NOEXEC flag */
>
> /*
> * Following constraints are specifc to FSL_PAMUV1:

Hmm, was this really intended to be a bitmap? Why? Thanks,

Alex