From: Andrew Jones <drjones@redhat.com>
To: pbonzini@redhat.com, jan.kiszka@siemens.com
Cc: kvm@vger.kernel.org
Subject: [PATCH kvm-unit-tests] report: add report_xfail for expected failures
Date: Tue, 17 Jun 2014 16:36:48 +0200 [thread overview]
Message-ID: <1403015808-20909-1-git-send-email-drjones@redhat.com> (raw)
Add report_xfail(), which is report(), but with another condition
allowing it to output PASS/FAIL/XPASS/XFAIL, rather than only
PASS/FAIL. This allows report output to stay more consistent
between systems/configurations that may or may not support all
tests.
Signed-off-by: Andrew Jones <drjones@redhat.com>
---
lib/libcflat.h | 1 +
lib/report.c | 37 +++++++++++++++++++++++++++++--------
2 files changed, 30 insertions(+), 8 deletions(-)
diff --git a/lib/libcflat.h b/lib/libcflat.h
index cb6663d33ef5a..c9577350ec275 100644
--- a/lib/libcflat.h
+++ b/lib/libcflat.h
@@ -63,5 +63,6 @@ extern long atol(const char *ptr);
#define NULL ((void *)0UL)
void report(const char *msg_fmt, bool pass, ...);
+void report_xfail(const char *msg_fmt, bool xfail, bool pass, ...);
int report_summary(void);
#endif
diff --git a/lib/report.c b/lib/report.c
index ff562a13c541e..43d7a65ec8812 100644
--- a/lib/report.c
+++ b/lib/report.c
@@ -5,32 +5,53 @@
*
* Authors:
* Jan Kiszka <jan.kiszka@siemens.com>
+ * Andrew Jones <drjones@redhat.com>
*
* This work is licensed under the terms of the GNU LGPL, version 2.
*/
#include "libcflat.h"
-static unsigned int tests, failures;
+static unsigned int tests, failures, xfailures;
-void report(const char *msg_fmt, bool pass, ...)
+void va_report_xfail(const char *msg_fmt, bool xfail, bool cond, va_list va)
{
+ char *pass = xfail ? "XPASS" : "PASS";
+ char *fail = xfail ? "XFAIL" : "FAIL";
char buf[2000];
- va_list va;
tests++;
- printf("%s: ", pass ? "PASS" : "FAIL");
- va_start(va, pass);
+ printf("%s: ", cond ? pass : fail);
vsnprintf(buf, sizeof(buf), msg_fmt, va);
- va_end(va);
puts(buf);
puts("\n");
- if (!pass)
+ if (xfail && cond)
+ failures++;
+ else if (xfail)
+ xfailures++;
+ else if (!cond)
failures++;
}
+void report(const char *msg_fmt, bool pass, ...)
+{
+ va_list va;
+ va_start(va, pass);
+ va_report_xfail(msg_fmt, false, pass, va);
+ va_end(va);
+}
+
+void report_xfail(const char *msg_fmt, bool xfail, bool pass, ...)
+{
+ va_list va;
+ va_start(va, pass);
+ va_report_xfail(msg_fmt, xfail, pass, va);
+ va_end(va);
+}
+
int report_summary(void)
{
- printf("\nSUMMARY: %d tests, %d failures\n", tests, failures);
+ printf("\nSUMMARY: %d tests, %d failures, %d xfailures\n",
+ tests, failures, xfailures);
return failures > 0 ? 1 : 0;
}
--
1.9.3
next reply other threads:[~2014-06-17 14:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-17 14:36 Andrew Jones [this message]
2014-06-17 18:46 ` [PATCH kvm-unit-tests] report: add report_xfail for expected failures Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1403015808-20909-1-git-send-email-drjones@redhat.com \
--to=drjones@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox