From: Scott Wood <scottwood@freescale.com>
To: Caraman Mihai Claudiu-B02008 <mihai.caraman@freescale.com>
Cc: "kvm-ppc@vger.kernel.org" <kvm-ppc@vger.kernel.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH v3] KVM: PPC: e500mc: Enhance tlb invalidation condition on vcpu schedule
Date: Tue, 17 Jun 2014 14:47:31 -0500 [thread overview]
Message-ID: <1403034451.6603.788.camel@snotra.buserror.net> (raw)
In-Reply-To: <37af68eb6855437892a438eec213d788@BY2PR03MB508.namprd03.prod.outlook.com>
On Tue, 2014-06-17 at 14:42 -0500, Caraman Mihai Claudiu-B02008 wrote:
> > > -static DEFINE_PER_CPU(struct kvm_vcpu *, last_vcpu_on_cpu);
> > > +static DEFINE_PER_CPU(struct kvm_vcpu * [KVMPPC_NR_LPIDS],
> > last_vcpu_on_cpu);
> >
> > Hmm, I didn't know you could express types like that. Is this special
> > syntax that only works for typeof?
>
> Yes, AFAIK.
>
> > No space after *
>
> Checkpatch complains about the missing space ;)
Checkpatch is wrong, which isn't surprising given that this is unusual
syntax. We don't normally put a space after * when used to represent a
pointer.
-Scott
next prev parent reply other threads:[~2014-06-17 19:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-17 19:09 [PATCH v3] KVM: PPC: e500mc: Enhance tlb invalidation condition on vcpu schedule Mihai Caraman
2014-06-17 19:18 ` Scott Wood
2014-06-17 19:42 ` mihai.caraman
2014-06-17 19:47 ` Scott Wood [this message]
2014-06-17 20:02 ` mihai.caraman
2014-06-17 20:05 ` Scott Wood
2014-06-17 20:36 ` mihai.caraman
2014-06-17 20:42 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1403034451.6603.788.camel@snotra.buserror.net \
--to=scottwood@freescale.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mihai.caraman@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox