From mboxrd@z Thu Jan 1 00:00:00 1970 From: Deng-Cheng Zhu Subject: [PATCH v3 7/9] MIPS: KVM: Fix memory leak on VCPU Date: Tue, 24 Jun 2014 10:31:08 -0700 Message-ID: <1403631071-6012-8-git-send-email-dengcheng.zhu@imgtec.com> References: <1403631071-6012-1-git-send-email-dengcheng.zhu@imgtec.com> Mime-Version: 1.0 Content-Type: text/plain Cc: , , , , , , To: Return-path: Received: from mailapp01.imgtec.com ([195.59.15.196]:46745 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755505AbaFXRbn (ORCPT ); Tue, 24 Jun 2014 13:31:43 -0400 In-Reply-To: <1403631071-6012-1-git-send-email-dengcheng.zhu@imgtec.com> Sender: kvm-owner@vger.kernel.org List-ID: From: Deng-Cheng Zhu kvm_arch_vcpu_free() is called in 2 code paths: 1) kvm_vm_ioctl() kvm_vm_ioctl_create_vcpu() kvm_arch_vcpu_destroy() kvm_arch_vcpu_free() 2) kvm_put_kvm() kvm_destroy_vm() kvm_arch_destroy_vm() kvm_mips_free_vcpus() kvm_arch_vcpu_free() Neither of the paths handles VCPU free. We need to do it in kvm_arch_vcpu_free() corresponding to the memory allocation in kvm_arch_vcpu_create(). Signed-off-by: Deng-Cheng Zhu --- Changes: v3 - v2: o Drop the merge of kvm_arch_vcpu_free() and pointer nullification. arch/mips/kvm/mips.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/mips/kvm/mips.c b/arch/mips/kvm/mips.c index 3d53d34..7f7fd76 100644 --- a/arch/mips/kvm/mips.c +++ b/arch/mips/kvm/mips.c @@ -384,6 +384,7 @@ void kvm_arch_vcpu_free(struct kvm_vcpu *vcpu) kfree(vcpu->arch.guest_ebase); kfree(vcpu->arch.kseg0_commpage); + kfree(vcpu); } void kvm_arch_vcpu_destroy(struct kvm_vcpu *vcpu) -- 1.8.5.3