From: Will Deacon <will.deacon@arm.com>
To: kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu
Cc: cornelia.huck@de.ibm.com, Alex.Williamson@redhat.com,
agraf@suse.de, gleb@kernel.org, pbonzini@redhat.com,
marc.zyngier@arm.com, christoffer.dall@linaro.org,
Will Deacon <will.deacon@arm.com>
Subject: [PATCH v2 3/4] KVM: s390: register flic ops dynamically
Date: Tue, 1 Jul 2014 15:45:17 +0100 [thread overview]
Message-ID: <1404225918-8903-3-git-send-email-will.deacon@arm.com> (raw)
In-Reply-To: <1404225918-8903-1-git-send-email-will.deacon@arm.com>
From: Cornelia Huck <cornelia.huck@de.ibm.com>
Using the new kvm_register_device_ops() interface makes us get rid of
an #ifdef in common code.
Cc: Gleb Natapov <gleb@kernel.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
---
arch/s390/kvm/kvm-s390.c | 3 ++-
arch/s390/kvm/kvm-s390.h | 1 +
include/linux/kvm_host.h | 1 -
virt/kvm/kvm_main.c | 4 ----
4 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
index 2f3e14fe91a4..d1d5296e6cdb 100644
--- a/arch/s390/kvm/kvm-s390.c
+++ b/arch/s390/kvm/kvm-s390.c
@@ -130,7 +130,8 @@ void kvm_arch_check_processor_compat(void *rtn)
int kvm_arch_init(void *opaque)
{
- return 0;
+ /* Register floating interrupt controller interface. */
+ return kvm_register_device_ops(&kvm_flic_ops, KVM_DEV_TYPE_FLIC);
}
void kvm_arch_exit(void)
diff --git a/arch/s390/kvm/kvm-s390.h b/arch/s390/kvm/kvm-s390.h
index a8655ed31616..b236a8ab7c6e 100644
--- a/arch/s390/kvm/kvm-s390.h
+++ b/arch/s390/kvm/kvm-s390.h
@@ -222,6 +222,7 @@ int kvm_cpu_has_interrupt(struct kvm_vcpu *vcpu);
int psw_extint_disabled(struct kvm_vcpu *vcpu);
void kvm_s390_destroy_adapters(struct kvm *kvm);
int kvm_s390_si_ext_call_pending(struct kvm_vcpu *vcpu);
+extern struct kvm_device_ops kvm_flic_ops;
/* implemented in guestdbg.c */
void kvm_s390_backup_guest_per_regs(struct kvm_vcpu *vcpu);
diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
index 4317fdd10696..422e55ac8a13 100644
--- a/include/linux/kvm_host.h
+++ b/include/linux/kvm_host.h
@@ -1088,7 +1088,6 @@ int kvm_register_device_ops(struct kvm_device_ops *ops, u32 type);
extern struct kvm_device_ops kvm_mpic_ops;
extern struct kvm_device_ops kvm_xics_ops;
extern struct kvm_device_ops kvm_vfio_ops;
-extern struct kvm_device_ops kvm_flic_ops;
#ifdef CONFIG_HAVE_KVM_CPU_RELAX_INTERCEPT
diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
index 7eab47222dcf..c9181db8abdd 100644
--- a/virt/kvm/kvm_main.c
+++ b/virt/kvm/kvm_main.c
@@ -2270,10 +2270,6 @@ static struct kvm_device_ops *kvm_device_ops_table[KVM_DEV_TYPE_MAX] = {
#ifdef CONFIG_KVM_VFIO
[KVM_DEV_TYPE_VFIO] = &kvm_vfio_ops,
#endif
-
-#ifdef CONFIG_S390
- [KVM_DEV_TYPE_FLIC] = &kvm_flic_ops,
-#endif
};
int kvm_register_device_ops(struct kvm_device_ops *ops, u32 type)
--
2.0.0
next prev parent reply other threads:[~2014-07-01 14:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-01 14:45 [PATCH v2 1/4] KVM: device: add simple registration mechanism for kvm_device_ops Will Deacon
2014-07-01 14:45 ` [PATCH v2 2/4] KVM: ARM: vgic: register kvm_device_ops dynamically Will Deacon
2014-07-09 16:05 ` Paolo Bonzini
2014-07-09 16:13 ` Marc Zyngier
2014-07-31 12:10 ` Christoffer Dall
2014-07-31 13:25 ` Will Deacon
2014-07-01 14:45 ` Will Deacon [this message]
2014-07-01 14:45 ` [PATCH v2 4/4] KVM: VFIO: " Will Deacon
2014-07-09 16:06 ` Paolo Bonzini
2014-07-09 16:19 ` Alex Williamson
2014-07-09 16:47 ` Will Deacon
2014-07-09 16:56 ` Alex Williamson
2014-07-09 16:56 ` Alex Williamson
2014-07-02 9:17 ` [PATCH v2 1/4] KVM: device: add simple registration mechanism for kvm_device_ops Cornelia Huck
2014-07-02 9:32 ` Will Deacon
2014-07-02 10:18 ` Cornelia Huck
2014-07-31 12:10 ` Christoffer Dall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1404225918-8903-3-git-send-email-will.deacon@arm.com \
--to=will.deacon@arm.com \
--cc=Alex.Williamson@redhat.com \
--cc=agraf@suse.de \
--cc=christoffer.dall@linaro.org \
--cc=cornelia.huck@de.ibm.com \
--cc=gleb@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=marc.zyngier@arm.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox