From: Alexander Graf <agraf@suse.de>
To: kvm-ppc@vger.kernel.org
Cc: kvm@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>,
Mihai Caraman <mihai.caraman@freescale.com>
Subject: [PULL 1/6] KVM: PPC: Book3E: Unlock mmu_lock when setting caching atttribute
Date: Tue, 8 Jul 2014 12:04:41 +0200 [thread overview]
Message-ID: <1404813886-14908-2-git-send-email-agraf@suse.de> (raw)
In-Reply-To: <1404813886-14908-1-git-send-email-agraf@suse.de>
From: Mihai Caraman <mihai.caraman@freescale.com>
The patch 08c9a188d0d0fc0f0c5e17d89a06bb59c493110f
kvm: powerpc: use caching attributes as per linux pte
do not handle properly the error case, letting mmu_lock locked. The lock
will further generate a RCU stall from kvmppc_e500_emul_tlbwe() caller.
In case of an error go to out label.
Signed-off-by: Mihai Caraman <mihai.caraman@freescale.com>
Signed-off-by: Alexander Graf <agraf@suse.de>
---
arch/powerpc/kvm/e500_mmu_host.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/kvm/e500_mmu_host.c b/arch/powerpc/kvm/e500_mmu_host.c
index dd2cc03..86903d3 100644
--- a/arch/powerpc/kvm/e500_mmu_host.c
+++ b/arch/powerpc/kvm/e500_mmu_host.c
@@ -473,7 +473,8 @@ static inline int kvmppc_e500_shadow_map(struct kvmppc_vcpu_e500 *vcpu_e500,
if (printk_ratelimit())
pr_err("%s: pte not present: gfn %lx, pfn %lx\n",
__func__, (long)gfn, pfn);
- return -EINVAL;
+ ret = -EINVAL;
+ goto out;
}
kvmppc_e500_ref_setup(ref, gtlbe, pfn, wimg);
--
1.8.1.4
next prev parent reply other threads:[~2014-07-08 10:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-08 10:04 [PULL 3.16 0/6] 3.16 patch queue 2014-07-08 Alexander Graf
2014-07-08 10:04 ` Alexander Graf [this message]
2014-07-08 10:04 ` [PULL 2/6] KVM: PPC: BOOK3S: HV: Use base page size when comparing against slb value Alexander Graf
2014-07-08 10:04 ` [PULL 3/6] PPC: Add _GLOBAL_TOC for 32bit Alexander Graf
2014-07-08 10:04 ` [PULL 4/6] KVM: PPC: Assembly functions exported to modules need _GLOBAL_TOC() Alexander Graf
2014-07-08 10:04 ` [PULL 5/6] KVM: PPC: Book3S PR: Fix ABIv2 on LE Alexander Graf
2014-07-08 10:04 ` [PULL 6/6] KVM: PPC: RTAS: Do byte swaps explicitly Alexander Graf
2014-07-08 10:13 ` [PULL 3.16 0/6] 3.16 patch queue 2014-07-08 Paolo Bonzini
2014-07-08 10:14 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1404813886-14908-2-git-send-email-agraf@suse.de \
--to=agraf@suse.de \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=mihai.caraman@freescale.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox