From: Andrew Jones <drjones@redhat.com>
To: linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc: uobergfe@redhat.com, dzickus@redhat.com, pbonzini@redhat.com,
akpm@linux-foundation.org, mingo@redhat.com
Subject: [PATCH 3/3] kvm: ensure hard lockup detection is disabled by default
Date: Thu, 24 Jul 2014 12:13:31 +0200 [thread overview]
Message-ID: <1406196811-5384-4-git-send-email-drjones@redhat.com> (raw)
In-Reply-To: <1406196811-5384-1-git-send-email-drjones@redhat.com>
From: Ulrich Obergfell <uobergfe@redhat.com>
Use watchdog_enable_hardlockup_detector() to set hard lockup detection's
default value to false. It's risky to run this detection in a guest, as
false positives are easy to trigger, especially if the host is
overcommitted.
Signed-off-by: Ulrich Obergfell <uobergfe@redhat.com>
Signed-off-by: Andrew Jones <drjones@redhat.com>
---
arch/x86/kernel/kvm.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c
index 3dd8e2c4d74a9..95c3cb16af3e5 100644
--- a/arch/x86/kernel/kvm.c
+++ b/arch/x86/kernel/kvm.c
@@ -35,6 +35,7 @@
#include <linux/slab.h>
#include <linux/kprobes.h>
#include <linux/debugfs.h>
+#include <linux/nmi.h>
#include <asm/timer.h>
#include <asm/cpu.h>
#include <asm/traps.h>
@@ -499,6 +500,13 @@ void __init kvm_guest_init(void)
#else
kvm_guest_cpu_init();
#endif
+
+ /*
+ * Hard lockup detection is enabled by default. Disable it, as guests
+ * can get false positives too easily, for example if the host is
+ * overcommitted.
+ */
+ watchdog_enable_hardlockup_detector(false);
}
static noinline uint32_t __kvm_cpuid_base(void)
--
1.9.3
prev parent reply other threads:[~2014-07-24 10:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-24 10:13 [PATCH 0/3] watchdog: kvm: disable hard lockup detection by default Andrew Jones
2014-07-24 10:13 ` [PATCH 1/3] watchdog: fix print-once on enable Andrew Jones
2014-07-24 10:13 ` [PATCH 2/3] watchdog: control hard lockup detection default Andrew Jones
2014-07-24 10:46 ` Paolo Bonzini
2014-07-24 11:18 ` Ulrich Obergfell
2014-07-24 11:26 ` Paolo Bonzini
2014-07-24 11:44 ` Ulrich Obergfell
2014-07-24 11:45 ` Paolo Bonzini
2014-07-24 12:02 ` Ulrich Obergfell
2014-07-25 8:32 ` Ulrich Obergfell
2014-07-25 11:25 ` Andrew Jones
2014-07-30 13:43 ` Don Zickus
2014-07-30 14:16 ` Paolo Bonzini
2014-07-30 17:07 ` Don Zickus
2014-08-08 13:53 ` [PATCH v2 " Andrew Jones
2014-07-24 10:13 ` Andrew Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1406196811-5384-4-git-send-email-drjones@redhat.com \
--to=drjones@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dzickus@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=uobergfe@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox