From: Scott Wood <scottwood@freescale.com>
To: Bhushan Bharat-R65777 <Bharat.Bhushan@freescale.com>
Cc: "agraf@suse.de" <agraf@suse.de>,
"kvm-ppc@vger.kernel.org" <kvm-ppc@vger.kernel.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"Yoder Stuart-B08248" <stuart.yoder@freescale.com>
Subject: Re: [PATCH 6/6] KVM: PPC: BOOKE: Emulate debug registers and exception
Date: Fri, 1 Aug 2014 22:35:31 -0500 [thread overview]
Message-ID: <1406950531.32071.2.camel@snotra.buserror.net> (raw)
In-Reply-To: <e05aca926e21471da18872b93c89dfb3@BLUPR03MB566.namprd03.prod.outlook.com>
On Fri, 2014-08-01 at 04:34 -0500, Bhushan Bharat-R65777 wrote:
> on dbsr write emulation, deque the debug interrupt even if DBSR_IDE is set.
>
> case SPRN_DBSR:
>
> vcpu->arch.dbsr &= ~spr_val;
> if (!(vcpu->arch.dbsr & ~DBSR_IDE))
> kvmppc_core_dequeue_debug(vcpu);
> break;
>
> or
> vcpu->arch.dbsr &= ~(spr_val | DBSR_IDE);
> if (!vcpu->arch.dbsr)
> kvmppc_core_dequeue_debug(vcpu);
> break;
The first option. I see no reason to have KVM forcibly clear DBSR[IDE].
-Scott
prev parent reply other threads:[~2014-08-02 3:35 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-11 8:38 [PATCH 0/6] Guest debug emulation Bharat Bhushan
2014-07-11 8:38 ` [PATCH 1/6] KVM: PPC: BOOKE: No need to set DBCR0_EDM in guest visible register Bharat Bhushan
2014-07-28 21:52 ` Scott Wood
2014-07-30 5:21 ` Bharat.Bhushan
2014-07-30 17:47 ` Scott Wood
2014-07-30 17:57 ` Bharat.Bhushan
2014-07-30 18:15 ` Scott Wood
2014-07-11 8:38 ` [PATCH 2/6] KVM: PPC: BOOKE: Force MSR_DE in rfci if guest is under debug Bharat Bhushan
2014-07-28 13:54 ` Alexander Graf
2014-07-28 21:54 ` Scott Wood
2014-07-30 5:30 ` Bharat.Bhushan
2014-07-11 8:38 ` [PATCH 3/6] KVM: PPC: BOOKE: allow debug interrupt at "debug level" Bharat Bhushan
2014-07-11 8:38 ` [PATCH 4/6] KVM: PPC: BOOKE : Emulate rfdi instruction Bharat Bhushan
2014-07-11 8:39 ` [PATCH 5/6] KVM: PPC: BOOKE: Allow guest to change MSR_DE Bharat Bhushan
2014-07-28 22:01 ` Scott Wood
2014-07-29 14:05 ` Alexander Graf
2014-07-30 5:37 ` Bharat.Bhushan
2014-07-11 8:39 ` [PATCH 6/6] KVM: PPC: BOOKE: Emulate debug registers and exception Bharat Bhushan
2014-07-28 14:04 ` Alexander Graf
2014-07-28 22:33 ` Scott Wood
2014-07-29 14:06 ` Alexander Graf
2014-07-29 17:50 ` Scott Wood
2014-07-29 18:23 ` Alexander Graf
2014-07-30 5:43 ` Bharat.Bhushan
2014-07-30 6:33 ` Alexander Graf
2014-07-30 6:49 ` Bharat.Bhushan
2014-07-28 22:28 ` Scott Wood
2014-07-30 6:43 ` Bharat.Bhushan
2014-07-31 2:47 ` Scott Wood
2014-07-31 6:15 ` Bharat.Bhushan
2014-07-31 20:45 ` Scott Wood
2014-08-01 9:34 ` Bharat.Bhushan
2014-08-02 3:35 ` Scott Wood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1406950531.32071.2.camel@snotra.buserror.net \
--to=scottwood@freescale.com \
--cc=Bharat.Bhushan@freescale.com \
--cc=agraf@suse.de \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=stuart.yoder@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox