From mboxrd@z Thu Jan  1 00:00:00 1970
From: Scott Wood <scottwood@freescale.com>
Subject: Re: [PATCH 6/6] KVM: PPC: BOOKE: Emulate debug registers and
 exception
Date: Fri, 1 Aug 2014 22:35:31 -0500
Message-ID: <1406950531.32071.2.camel@snotra.buserror.net>
References: <1405067941-27134-1-git-send-email-Bharat.Bhushan@freescale.com>
	 <1405067941-27134-7-git-send-email-Bharat.Bhushan@freescale.com>
	 <1406586501.29414.181.camel@snotra.buserror.net>
	 <fda708f6c0464f5f8261de034af5cb08@BLUPR03MB566.namprd03.prod.outlook.com>
	 <1406774874.29414.312.camel@snotra.buserror.net>
	 <ad9398a723594a9f93bc7f79549ab922@BLUPR03MB566.namprd03.prod.outlook.com>
	 <1406839542.29414.354.camel@snotra.buserror.net>
	 <e05aca926e21471da18872b93c89dfb3@BLUPR03MB566.namprd03.prod.outlook.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Cc: "agraf@suse.de" <agraf@suse.de>,
	"kvm-ppc@vger.kernel.org" <kvm-ppc@vger.kernel.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"Yoder Stuart-B08248" <stuart.yoder@freescale.com>
To: Bhushan Bharat-R65777 <Bharat.Bhushan@freescale.com>
Return-path: <kvm-ppc-owner@vger.kernel.org>
In-Reply-To: <e05aca926e21471da18872b93c89dfb3@BLUPR03MB566.namprd03.prod.outlook.com>
Sender: kvm-ppc-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

On Fri, 2014-08-01 at 04:34 -0500, Bhushan Bharat-R65777 wrote:
> on dbsr write emulation, deque the debug interrupt even if DBSR_IDE is set.
> 
>         case SPRN_DBSR:
> 
>                 vcpu->arch.dbsr &= ~spr_val;
>                 if (!(vcpu->arch.dbsr & ~DBSR_IDE))
>                         kvmppc_core_dequeue_debug(vcpu);
>                 break;
> 
> or
>                 vcpu->arch.dbsr &= ~(spr_val | DBSR_IDE);
>                 if (!vcpu->arch.dbsr)
>                         kvmppc_core_dequeue_debug(vcpu);
>                 break;

The first option.  I see no reason to have KVM forcibly clear DBSR[IDE].

-Scott