kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoffer Dall <christoffer.dall@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>, Gleb Natapov <gleb@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
	kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Marc Zyngier" <marc.zyngier@arm.com>
Subject: [GIT PULL 06/51] arm64: KVM: export demux regids as KVM_REG_ARM64
Date: Mon,  4 Aug 2014 10:46:23 +0200	[thread overview]
Message-ID: <1407142028-31105-7-git-send-email-christoffer.dall@linaro.org> (raw)
In-Reply-To: <1407142028-31105-1-git-send-email-christoffer.dall@linaro.org>

From: Alex Bennée <alex.bennee@linaro.org>

I suspect this is a -ECUTPASTE fault from the initial implementation. If
we don't declare the register ID to be KVM_REG_ARM64 the KVM_GET_ONE_REG
implementation kvm_arm_get_reg() returns -EINVAL and hilarity ensues.

The kvm/api.txt document describes all arm64 registers as starting with
0x60xx... (i.e KVM_REG_ARM64).

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Acked-by: Christoffer Dall <christoffer.dall@linaro.org>
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
---
 arch/arm64/kvm/sys_regs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/kvm/sys_regs.c b/arch/arm64/kvm/sys_regs.c
index c59a1bd..34f25a5 100644
--- a/arch/arm64/kvm/sys_regs.c
+++ b/arch/arm64/kvm/sys_regs.c
@@ -962,7 +962,7 @@ static unsigned int num_demux_regs(void)
 
 static int write_demux_regids(u64 __user *uindices)
 {
-	u64 val = KVM_REG_ARM | KVM_REG_SIZE_U32 | KVM_REG_ARM_DEMUX;
+	u64 val = KVM_REG_ARM64 | KVM_REG_SIZE_U32 | KVM_REG_ARM_DEMUX;
 	unsigned int i;
 
 	val |= KVM_REG_ARM_DEMUX_ID_CCSIDR;
-- 
2.0.0


  parent reply	other threads:[~2014-08-04  8:47 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-04  8:46 [GIT PULL 00/51] KVM/ARM updates for 3.17 Christoffer Dall
2014-08-04  8:46 ` [GIT PULL 01/51] irqchip: gic: Move some bits of GICv2 to a library-type file Christoffer Dall
2014-08-04  8:46 ` [GIT PULL 02/51] irqchip: gic-v3: Initial support for GICv3 Christoffer Dall
2014-08-04  8:46 ` [GIT PULL 03/51] arm/arm64: KVM: Fix and refactor unmap_range Christoffer Dall
2014-08-04  8:46 ` [GIT PULL 04/51] ARM: KVM: Unmap IPA on memslot delete/move Christoffer Dall
2014-08-04  8:46 ` [GIT PULL 05/51] ARM: KVM: user_mem_abort: support stage 2 MMIO page mapping Christoffer Dall
2014-08-04  8:46 ` Christoffer Dall [this message]
2014-08-04  8:46 ` [GIT PULL 07/51] arm64: KVM: allow export and import of generic timer regs Christoffer Dall
2014-08-04  8:46 ` [GIT PULL 08/51] arm64: GICv3 device tree binding documentation Christoffer Dall
2014-08-04  8:46 ` [GIT PULL 09/51] arm64: boot protocol documentation update for GICv3 Christoffer Dall
2014-08-04  8:46 ` [GIT PULL 10/51] KVM: arm/arm64: vgic: move GICv2 registers to their own structure Christoffer Dall
2014-08-04  8:46 ` [GIT PULL 11/51] KVM: ARM: vgic: introduce vgic_ops and LR manipulation primitives Christoffer Dall
2014-08-04  8:46 ` [GIT PULL 12/51] KVM: ARM: vgic: abstract access to the ELRSR bitmap Christoffer Dall
2014-08-04  8:46 ` [GIT PULL 13/51] KVM: ARM: vgic: abstract EISR bitmap access Christoffer Dall
2014-08-04  8:46 ` [GIT PULL 14/51] KVM: ARM: vgic: abstract MISR decoding Christoffer Dall
2014-08-04  8:46 ` [GIT PULL 15/51] KVM: ARM: vgic: move underflow handling to vgic_ops Christoffer Dall
2014-08-04  8:46 ` [GIT PULL 16/51] KVM: ARM: vgic: abstract VMCR access Christoffer Dall
2014-08-04  8:46 ` [GIT PULL 17/51] KVM: ARM: vgic: introduce vgic_enable Christoffer Dall
2014-08-04  8:46 ` [GIT PULL 18/51] KVM: ARM: introduce vgic_params structure Christoffer Dall
2014-08-04  8:46 ` [GIT PULL 19/51] KVM: ARM: vgic: split GICv2 backend from the main vgic code Christoffer Dall
2014-08-04  8:46 ` [GIT PULL 20/51] KVM: ARM: vgic: revisit implementation of irqchip_in_kernel Christoffer Dall
2014-08-04  8:46 ` [GIT PULL 21/51] arm64: KVM: remove __kvm_hyp_code_{start,end} from hyp.S Christoffer Dall
2014-08-04  8:46 ` [GIT PULL 22/51] arm64: KVM: split GICv2 world switch from hyp code Christoffer Dall
2014-08-04  8:46 ` [GIT PULL 23/51] arm64: KVM: move HCR_EL2.{IMO,FMO} manipulation into the vgic switch code Christoffer Dall
2014-08-04  8:46 ` [GIT PULL 24/51] KVM: ARM: vgic: add the GICv3 backend Christoffer Dall
2014-08-04  8:46 ` [GIT PULL 25/51] arm64: KVM: vgic: add GICv3 world switch Christoffer Dall
2014-08-04  8:46 ` [GIT PULL 26/51] arm64: KVM: vgic: enable GICv2 emulation on top on GICv3 hardware Christoffer Dall
2014-08-04  8:46 ` [GIT PULL 27/51] ARM: virt: fix wrong HSCTLR.EE bit setting Christoffer Dall
2014-08-04  8:46 ` [GIT PULL 28/51] ARM: KVM: fix vgic V7 assembler code to work in BE image Christoffer Dall
2014-08-04  8:46 ` [GIT PULL 29/51] ARM: KVM: handle 64bit values passed to mrcc or from mcrr instructions in BE case Christoffer Dall
2014-08-04  8:46 ` [GIT PULL 30/51] ARM: KVM: __kvm_vcpu_run function return result fix " Christoffer Dall
2014-08-04  8:46 ` [GIT PULL 31/51] ARM: KVM: vgic mmio should hold data as LE bytes array " Christoffer Dall
2014-08-04  8:46 ` [GIT PULL 32/51] ARM: KVM: MMIO support BE host running LE code Christoffer Dall
2014-08-04  8:46 ` [GIT PULL 33/51] ARM: KVM: one_reg coproc set and get BE fixes Christoffer Dall
2014-08-04  8:46 ` [GIT PULL 34/51] ARM: KVM: enable KVM in Kconfig on big-endian systems Christoffer Dall
2014-08-04  8:46 ` [GIT PULL 35/51] ARM64: KVM: MMIO support BE host running LE code Christoffer Dall
2014-08-04  8:46 ` [GIT PULL 36/51] ARM64: KVM: store kvm_vcpu_fault_info est_el2 as word Christoffer Dall
2014-08-04  8:46 ` [GIT PULL 37/51] ARM64: KVM: fix vgic_bitmap_get_reg function for BE 64bit case Christoffer Dall
2014-08-04  8:46 ` [GIT PULL 38/51] ARM64: KVM: set and get of sys registers in BE case Christoffer Dall
2014-08-04  8:46 ` [GIT PULL 39/51] ARM64: KVM: fix big endian issue in access_vm_reg for 32bit guest Christoffer Dall
2014-08-04  8:46 ` [GIT PULL 40/51] arm64: KVM: rename pm_fake handler to trap_raz_wi Christoffer Dall
2014-08-04  8:46 ` [GIT PULL 41/51] arm64: move DBG_MDSCR_* to asm/debug-monitors.h Christoffer Dall
2014-08-04  8:46 ` [GIT PULL 42/51] arm64: KVM: add trap handlers for AArch64 debug registers Christoffer Dall
2014-08-04  8:47 ` [GIT PULL 43/51] arm64: KVM: common infrastructure for handling AArch32 CP14/CP15 Christoffer Dall
2014-08-04  8:47 ` [GIT PULL 44/51] arm64: KVM: use separate tables for AArch32 32 and 64bit traps Christoffer Dall
2014-08-04  8:47 ` [GIT PULL 45/51] arm64: KVM: check ordering of all system register tables Christoffer Dall
2014-08-04  8:47 ` [GIT PULL 46/51] arm64: KVM: add trap handlers for AArch32 debug registers Christoffer Dall
2014-08-04  8:47 ` [GIT PULL 47/51] arm64: KVM: implement lazy world switch for " Christoffer Dall
2014-08-04  8:47 ` [GIT PULL 48/51] arm64: KVM: enable trapping of all " Christoffer Dall
2014-08-04  8:47 ` [GIT PULL 49/51] arm64: KVM: GICv3: move system register access to msr_s/mrs_s Christoffer Dall
2014-08-04  8:47 ` [GIT PULL 50/51] KVM: arm64: GICv3: mandate page-aligned GICV region Christoffer Dall
2014-08-04  8:47 ` [GIT PULL 51/51] arm64: KVM: fix 64bit CP15 VM access for 32bit guests Christoffer Dall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1407142028-31105-7-git-send-email-christoffer.dall@linaro.org \
    --to=christoffer.dall@linaro.org \
    --cc=alex.bennee@linaro.org \
    --cc=gleb@kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=marc.zyngier@arm.com \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).