kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Anup Patel <anup.patel@linaro.org>
To: kvmarm@lists.cs.columbia.edu
Cc: linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org,
	patches@apm.com, marc.zyngier@arm.com,
	christoffer.dall@linaro.org, will.deacon@arm.com,
	ian.campbell@citrix.com, pranavkumar@linaro.org,
	Anup Patel <anup.patel@linaro.org>
Subject: [RFC PATCH 3/6] ARM: perf: Re-enable overflow interrupt from interrupt handler
Date: Tue,  5 Aug 2014 14:54:12 +0530	[thread overview]
Message-ID: <1407230655-28864-4-git-send-email-anup.patel@linaro.org> (raw)
In-Reply-To: <1407230655-28864-1-git-send-email-anup.patel@linaro.org>

A hypervisor will typically mask the overflow interrupt before
forwarding it to Guest Linux hence we need to re-enable the overflow
interrupt after clearing it in Guest Linux. Also, this re-enabling
of overflow interrupt does not harm in non-virtualized scenarios.

Signed-off-by: Pranavkumar Sawargaonkar <pranavkumar@linaro.org>
Signed-off-by: Anup Patel <anup.patel@linaro.org>
---
 arch/arm/kernel/perf_event_v7.c |    8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm/kernel/perf_event_v7.c b/arch/arm/kernel/perf_event_v7.c
index 1d37568..581cca5 100644
--- a/arch/arm/kernel/perf_event_v7.c
+++ b/arch/arm/kernel/perf_event_v7.c
@@ -1355,6 +1355,14 @@ static irqreturn_t armv7pmu_handle_irq(int irq_num, void *dev)
 		if (!armv7_pmnc_counter_has_overflowed(pmnc, idx))
 			continue;
 
+		/*
+		 * If we are running under a hypervisor such as KVM then
+		 * hypervisor will mask the interrupt before forwarding
+		 * it to Guest Linux hence re-enable interrupt for the
+		 * overflowed counter.
+		 */
+		armv7_pmnc_enable_intens(idx);
+
 		hwc = &event->hw;
 		armpmu_event_update(event);
 		perf_sample_data_init(&data, 0, hwc->last_period);
-- 
1.7.9.5


  parent reply	other threads:[~2014-08-05  9:24 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-05  9:24 [RFC PATCH 0/6] ARM64: KVM: PMU infrastructure support Anup Patel
2014-08-05  9:24 ` [RFC PATCH 1/6] ARM64: Move PMU register related defines to asm/pmu.h Anup Patel
2014-08-05  9:24 ` [RFC PATCH 2/6] ARM64: perf: Re-enable overflow interrupt from interrupt handler Anup Patel
2014-08-06 14:24   ` Will Deacon
2014-08-07  9:03     ` Anup Patel
2014-08-07  9:06       ` Will Deacon
2014-08-05  9:24 ` Anup Patel [this message]
2014-08-05  9:24 ` [RFC PATCH 4/6] ARM/ARM64: KVM: Add common code PMU IRQ routing Anup Patel
2014-08-05  9:24 ` [RFC PATCH 5/6] ARM64: KVM: Implement full context switch of PMU registers Anup Patel
2014-08-05  9:24 ` [RFC PATCH 6/6] ARM64: KVM: Upgrade to lazy " Anup Patel
2014-08-05  9:32 ` [RFC PATCH 0/6] ARM64: KVM: PMU infrastructure support Anup Patel
2014-08-05  9:35   ` Anup Patel
2014-11-07 20:23 ` Christoffer Dall
2014-11-07 20:25 ` Christoffer Dall
2014-11-08  9:36   ` Anup Patel
2014-11-08 12:39     ` Christoffer Dall
2014-11-11  9:18       ` Anup Patel
2014-11-18  3:24         ` Anup Patel
2014-11-19 15:29         ` Christoffer Dall
2014-11-20 14:47           ` Anup Patel
2014-11-21  9:59             ` Christoffer Dall
2014-11-21 10:36               ` Anup Patel
2014-11-21 11:49                 ` Christoffer Dall
2014-11-24  8:44                   ` Anup Patel
2014-11-24 14:37                     ` Christoffer Dall
2014-11-25 12:47                       ` Anup Patel
2014-11-25 13:42                         ` Christoffer Dall
2014-11-27 10:22                           ` Anup Patel
2014-11-27 10:40                             ` Marc Zyngier
2014-11-27 10:54                               ` Anup Patel
2014-11-27 11:06                                 ` Marc Zyngier
2014-12-30  5:49                                   ` Anup Patel
2015-01-08  4:02                                     ` Anup Patel
2015-01-11 19:11                                     ` Christoffer Dall
2015-01-12  4:19                                       ` Anup Patel
2015-02-15 15:33                                         ` Christoffer Dall
2015-02-16 12:16                                           ` Anup Patel
2015-02-16 12:23                                             ` Christoffer Dall
2015-01-14  4:28                                       ` Anup Patel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1407230655-28864-4-git-send-email-anup.patel@linaro.org \
    --to=anup.patel@linaro.org \
    --cc=christoffer.dall@linaro.org \
    --cc=ian.campbell@citrix.com \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=marc.zyngier@arm.com \
    --cc=patches@apm.com \
    --cc=pranavkumar@linaro.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).