From mboxrd@z Thu Jan  1 00:00:00 1970
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: Re: [PATCH v2 4/4] vfio_pci: spapr: Enable VFIO if EEH is not
 supported
Date: Wed, 06 Aug 2014 14:34:44 +1000
Message-ID: <1407299684.3073.62.camel@pasglop>
References: <1407293313-24894-1-git-send-email-aik@ozlabs.ru>
	 <1407293313-24894-5-git-send-email-aik@ozlabs.ru>
	 <1407296659.316.78.camel@ul30vt.home>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>,
	linuxppc-dev@lists.ozlabs.org,
	Gavin Shan <gwshan@linux.vnet.ibm.com>, kvm@vger.kernel.org
To: Alex Williamson <alex.williamson@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from gate.crashing.org ([63.228.1.57]:40602 "EHLO gate.crashing.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750964AbaHFEfE (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 6 Aug 2014 00:35:04 -0400
In-Reply-To: <1407296659.316.78.camel@ul30vt.home>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Tue, 2014-08-05 at 21:44 -0600, Alex Williamson wrote:
> >               ret = vfio_spapr_pci_eeh_open(vdev->pdev);
> > -             if (ret) {
> > -                     vfio_pci_disable(vdev);
> > -                     goto error;
> > -             }
> > +             if (ret)
> > +                     pr_warn_once("EEH is not supported\n");
> >       }
> >  
> >       return 0;
> 
> Now the next question, what's the point of vfio_spapr_pci_eeh_open()
> returning a value?  Couldn't it return void now and this warning can
> go into eeh specific code?  Thanks,

In order to call vfio_pci_disable() when that happens ?

Cheers,
Ben.