From: Scott Wood <scottwood@freescale.com>
To: Bharat Bhushan <Bharat.Bhushan@freescale.com>
Cc: <agraf@suse.de>, <kvm-ppc@vger.kernel.org>, <kvm@vger.kernel.org>,
<stuart.yoder@freescale.com>
Subject: Re: [PATCH 7/7 v3] KVM: PPC: BOOKE: Emulate debug registers and exception
Date: Mon, 11 Aug 2014 19:00:08 -0500 [thread overview]
Message-ID: <1407801608.7427.119.camel@snotra.buserror.net> (raw)
In-Reply-To: <1407307137-5083-8-git-send-email-Bharat.Bhushan@freescale.com>
On Wed, 2014-08-06 at 12:08 +0530, Bharat Bhushan wrote:
> @@ -1249,6 +1284,7 @@ int kvmppc_subarch_vcpu_init(struct kvm_vcpu *vcpu)
> setup_timer(&vcpu->arch.wdt_timer, kvmppc_watchdog_func,
> (unsigned long)vcpu);
>
> + kvmppc_clear_dbsr();
> return 0;
This could use a comment for why we're doing this. Also, I'm a bit
uneasy about clearing the whole DBSR here, where we haven't yet switched
the debug registers to guest context. It shouldn't actually matter
except for deferred debug exceptions which are not actually useful (in
fact e6500 removed support for them), but still...
-Scott
next prev parent reply other threads:[~2014-08-12 0:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-06 6:38 [PATCH 0/7 v3] Guest debug emulation Bharat Bhushan
2014-08-06 6:38 ` [PATCH 1/7 v3] KVM: PPC: BOOKE: allow debug interrupt at "debug level" Bharat Bhushan
2014-08-06 6:38 ` [PATCH 2/7 v3] KVM: PPC: BOOKE : Emulate rfdi instruction Bharat Bhushan
2014-08-06 6:38 ` [PATCH 3/7 v3] KVM: PPC: BOOKE: Allow guest to change MSR_DE Bharat Bhushan
2014-08-06 6:38 ` [PATCH 4/7 v3] KVM: PPC: BOOKE: Clear guest dbsr in userspace exit KVM_EXIT_DEBUG Bharat Bhushan
2014-08-06 6:38 ` [PATCH 5/7 v3] KVM: PPC: BOOKE: Guest and hardware visible debug registers are same Bharat Bhushan
2014-08-06 6:38 ` [PATCH 6/7 v3] KVM: PPC: BOOKE: Add one reg interface for DBSR Bharat Bhushan
2014-08-12 10:24 ` Alexander Graf
2014-08-06 6:38 ` [PATCH 7/7 v3] KVM: PPC: BOOKE: Emulate debug registers and exception Bharat Bhushan
2014-08-12 0:00 ` Scott Wood [this message]
2014-08-12 7:36 ` Bharat.Bhushan
2014-08-12 19:46 ` Scott Wood
2014-08-12 10:25 ` [PATCH 0/7 v3] Guest debug emulation Alexander Graf
2014-08-12 10:27 ` Bharat.Bhushan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1407801608.7427.119.camel@snotra.buserror.net \
--to=scottwood@freescale.com \
--cc=Bharat.Bhushan@freescale.com \
--cc=agraf@suse.de \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=stuart.yoder@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox