From: Wei Wang <wei.w.wang@intel.com>
To: kvm@vger.kernel.org
Cc: pbonzini@redhat.com, alex.williamson@redhat.com,
Wei Wang <wei.w.wang@intel.com>,
Yang Zhang <yang.z.zhang@intel.com>
Subject: [PATCH] KVM: x86: sync old tmr with ioapic to update
Date: Wed, 27 Aug 2014 00:27:21 +0800 [thread overview]
Message-ID: <1409070441-31239-1-git-send-email-wei.w.wang@intel.com> (raw)
kvm_ioapic_scan_entry() needs to update tmr. The previous lapic tmr value
(old_tmr) needs to sync with ioapic to get an accurate updated tmr
value before the updating work.
Tested-by: Rongrong Liu <rongrongx.liu@intel.com>
Signed-off-by: Yang Zhang <yang.z.zhang@intel.com>
Signed-off-by: Wei Wang <wei.w.wang@intel.com>
---
arch/x86/kvm/lapic.c | 11 ++++++++++-
arch/x86/kvm/x86.c | 2 +-
2 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c
index 08e8a89..93c2e93 100644
--- a/arch/x86/kvm/lapic.c
+++ b/arch/x86/kvm/lapic.c
@@ -518,10 +518,19 @@ static void pv_eoi_clr_pending(struct kvm_vcpu *vcpu)
void kvm_apic_update_tmr(struct kvm_vcpu *vcpu, u32 *tmr)
{
struct kvm_lapic *apic = vcpu->arch.apic;
+ u32 irr[8];
+ u32 isr[8];
+ u32 old_tmr[8];
int i;
- for (i = 0; i < 8; i++)
+ for (i = 0; i < 8; i++) {
+ irr[i] = kvm_apic_get_reg(apic, APIC_IRR + 0x10 * i);
+ isr[i] = kvm_apic_get_reg(apic, APIC_ISR + 0x10 * i);
+ old_tmr[i] = kvm_apic_get_reg(apic, APIC_TMR + 0x10 * i);
+ tmr[i] = (~(irr[i] | isr[i]) & tmr[i])
+ | ((irr[i] | isr[i]) & old_tmr[i]);
apic_set_reg(apic, APIC_TMR + 0x10 * i, tmr[i]);
+ }
}
static void apic_update_ppr(struct kvm_lapic *apic)
diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index 5f5edb6..d401684 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -5991,8 +5991,8 @@ static void vcpu_scan_ioapic(struct kvm_vcpu *vcpu)
memset(tmr, 0, 32);
kvm_ioapic_scan_entry(vcpu, eoi_exit_bitmap, tmr);
- kvm_x86_ops->load_eoi_exitmap(vcpu, eoi_exit_bitmap);
kvm_apic_update_tmr(vcpu, tmr);
+ kvm_x86_ops->load_eoi_exitmap(vcpu, eoi_exit_bitmap);
}
/*
--
1.7.1
next reply other threads:[~2014-08-26 8:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-26 16:27 Wei Wang [this message]
2014-08-26 10:58 ` [PATCH] KVM: x86: sync old tmr with ioapic to update Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409070441-31239-1-git-send-email-wei.w.wang@intel.com \
--to=wei.w.wang@intel.com \
--cc=alex.williamson@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=yang.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox