From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andres Lagar-Cavilla Subject: [PATCH] kvm: Fix kvm_get_page_retry_io __gup retval check Date: Thu, 25 Sep 2014 15:26:50 -0700 Message-ID: <1411684010-883-1-git-send-email-andreslc@google.com> Cc: Andres Lagar-Cavilla To: Paolo Bonzini , Andrea Arcangeli , Gleb Natapov , kvm@vger.kernel.org Return-path: Received: from mail-ob0-f202.google.com ([209.85.214.202]:62612 "EHLO mail-ob0-f202.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751568AbaIYW1I (ORCPT ); Thu, 25 Sep 2014 18:27:08 -0400 Received: by mail-ob0-f202.google.com with SMTP id wo20so1644971obc.3 for ; Thu, 25 Sep 2014 15:27:07 -0700 (PDT) Sender: kvm-owner@vger.kernel.org List-ID: Confusion around -EBUSY and zero (inside a BUG_ON no less). Reported-by: AndreA Arcangeli Signed-off-by: Andres Lagar-Cavilla --- virt/kvm/kvm_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index 3f16f56..a1cf53e 100644 --- a/virt/kvm/kvm_main.c +++ b/virt/kvm/kvm_main.c @@ -1146,7 +1146,7 @@ int kvm_get_user_page_io(struct task_struct *tsk, struct mm_struct *mm, npages = __get_user_pages(tsk, mm, addr, 1, flags, pagep, NULL, &locked); if (!locked) { - VM_BUG_ON(npages != -EBUSY); + VM_BUG_ON(npages); if (!pagep) return 0; -- 2.1.0.rc2.206.gedb03e5