From: Wei Wang <wei.w.wang@intel.com>
To: kvm@vger.kernel.org
Cc: pbonzini@redhat.com, Wei Wang <wei.w.wang@intel.com>,
Yang Zhang <yang.z.zhang@intel.com>
Subject: [PATCH] KVM: x86: reset RVI upon system reset
Date: Wed, 5 Nov 2014 10:53:43 +0800 [thread overview]
Message-ID: <1415156023-1349-1-git-send-email-wei.w.wang@intel.com> (raw)
A bug was reported as follows: when running Windows 7 32-bit guests on qemu-kvm,
sometimes the guests run into blue screen during reboot. The problem was that a
guest's RVI was not cleared when it rebooted. This patch has fixed the problem.
Signed-off-by: Wei Wang <wei.w.wang@intel.com>
Signed-off-by: Yang Zhang <yang.z.zhang@intel.com>
Tested-by: Rongrong Liu <rongrongx.liu@intel.com>, Da Chun <ngugc@qq.com>
---
arch/x86/kvm/lapic.c | 3 +++
arch/x86/kvm/vmx.c | 12 ++++++------
2 files changed, 9 insertions(+), 6 deletions(-)
diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c
index 66dd173..6942742 100644
--- a/arch/x86/kvm/lapic.c
+++ b/arch/x86/kvm/lapic.c
@@ -1712,6 +1712,9 @@ void kvm_apic_post_state_restore(struct kvm_vcpu *vcpu,
apic->isr_count = kvm_apic_vid_enabled(vcpu->kvm) ?
1 : count_vectors(apic->regs + APIC_ISR);
apic->highest_isr_cache = -1;
+ if (kvm_x86_ops->hwapic_irr_update)
+ kvm_x86_ops->hwapic_irr_update(vcpu,
+ apic_find_highest_irr(apic));
kvm_x86_ops->hwapic_isr_update(vcpu->kvm, apic_find_highest_isr(apic));
kvm_make_request(KVM_REQ_EVENT, vcpu);
kvm_rtc_eoi_tracking_restore_one(vcpu);
diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
index fe4d2f4..d632548 100644
--- a/arch/x86/kvm/vmx.c
+++ b/arch/x86/kvm/vmx.c
@@ -7292,19 +7292,19 @@ static void vmx_set_rvi(int vector)
static void vmx_hwapic_irr_update(struct kvm_vcpu *vcpu, int max_irr)
{
if (max_irr == -1)
+ max_irr = 0;
+
+ if (!is_guest_mode(vcpu)) {
+ vmx_set_rvi(max_irr);
return;
+ }
/*
* If a vmexit is needed, vmx_check_nested_events handles it.
*/
- if (is_guest_mode(vcpu) && nested_exit_on_intr(vcpu))
+ if ((is_guest_mode(vcpu) && nested_exit_on_intr(vcpu)) || max_irr == 0)
return;
- if (!is_guest_mode(vcpu)) {
- vmx_set_rvi(max_irr);
- return;
- }
-
/*
* Fall back to pre-APICv interrupt injection since L2
* is run without virtual interrupt delivery.
--
1.7.1
next reply other threads:[~2014-11-05 2:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-05 2:53 Wei Wang [this message]
2014-11-05 6:13 ` [PATCH] KVM: x86: reset RVI upon system reset Chen, Tiejun
2014-11-05 7:39 ` Wang, Wei W
2014-11-05 8:06 ` Chen, Tiejun
2014-11-05 8:50 ` Wang, Wei W
2014-11-05 9:02 ` Chen, Tiejun
2014-11-05 10:02 ` Paolo Bonzini
2014-11-06 1:08 ` Zhang, Yang Z
2014-12-11 8:15 ` Zhang Haoyu
2014-12-11 11:06 ` Zhang, Yang Z
2014-12-12 9:56 ` Zhang Haoyu
2014-12-12 10:27 ` Paolo Bonzini
2014-12-15 1:52 ` Zhang Haoyu
2014-12-15 9:32 ` Paolo Bonzini
2014-12-11 11:35 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415156023-1349-1-git-send-email-wei.w.wang@intel.com \
--to=wei.w.wang@intel.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=yang.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox