public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: virtualization@lists.linux-foundation.org, qemu-devel@nongnu.org,
	kvm@vger.kernel.org
Cc: rusty@rustcorp.com.au, thuth@linux.vnet.ibm.com, mst@redhat.com,
	Cornelia Huck <cornelia.huck@de.ibm.com>
Subject: [PATCH RFC v3 11/12] virtio-net/virtio-blk: enable virtio 1.0
Date: Wed, 26 Nov 2014 18:28:42 +0100	[thread overview]
Message-ID: <1417022923-1654-12-git-send-email-cornelia.huck@de.ibm.com> (raw)
In-Reply-To: <1417022923-1654-1-git-send-email-cornelia.huck@de.ibm.com>

virtio-net (non-vhost) and virtio-blk have everything in place to support
virtio 1.0: let's enable the feature bit for them.

Note that VIRTIO_F_VERSION_1 is technically a transport feature; once
every device is ready for virtio 1.0, we can move this setting this
feature bit out of the individual devices.

Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
---
 hw/block/virtio-blk.c |    4 ++++
 hw/net/virtio-net.c   |    4 ++++
 2 files changed, 8 insertions(+)

diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
index 6d86f60..3781f98 100644
--- a/hw/block/virtio-blk.c
+++ b/hw/block/virtio-blk.c
@@ -569,6 +569,10 @@ static uint32_t virtio_blk_get_features(VirtIODevice *vdev, unsigned int index,
 {
     VirtIOBlock *s = VIRTIO_BLK(vdev);
 
+    if (index == 1) {
+        features |= (1 << (VIRTIO_F_VERSION_1 - 32));
+    }
+
     if (index > 0) {
         return features;
     }
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
index 1e214b5..fcfc95f 100644
--- a/hw/net/virtio-net.c
+++ b/hw/net/virtio-net.c
@@ -447,6 +447,10 @@ static uint32_t virtio_net_get_features(VirtIODevice *vdev, unsigned int index,
     VirtIONet *n = VIRTIO_NET(vdev);
     NetClientState *nc = qemu_get_queue(n->nic);
 
+    if (index == 1 && !get_vhost_net(nc->peer)) {
+        features |= (1 << (VIRTIO_F_VERSION_1 - 32));
+    }
+
     if (index > 0) {
         return features;
     }
-- 
1.7.9.5


  parent reply	other threads:[~2014-11-26 17:29 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-26 17:28 [PATCH RFC v3 00/12] qemu: towards virtio-1 host support Cornelia Huck
2014-11-26 17:28 ` [PATCH RFC v3 01/12] linux-headers/virtio_config: Update with VIRTIO_F_VERSION_1 Cornelia Huck
2014-11-26 17:28 ` [PATCH RFC v3 02/12] virtio: cull virtio_bus_set_vdev_features Cornelia Huck
2014-11-26 17:28 ` [PATCH RFC v3 03/12] virtio: support more feature bits Cornelia Huck
2014-11-26 17:28 ` [PATCH RFC v3 04/12] s390x/virtio-ccw: fix check for WRITE_FEAT Cornelia Huck
2014-11-26 17:28 ` [PATCH RFC v3 05/12] virtio: introduce legacy virtio devices Cornelia Huck
2014-11-26 18:46   ` [Qemu-devel] " Greg Kurz
2014-11-26 18:51     ` Michael S. Tsirkin
2014-11-26 17:28 ` [PATCH RFC v3 06/12] virtio: allow virtio-1 queue layout Cornelia Huck
2014-11-26 17:28 ` [PATCH RFC v3 07/12] dataplane: allow virtio-1 devices Cornelia Huck
2014-11-26 18:15   ` Greg Kurz
2014-11-26 17:28 ` [PATCH RFC v3 08/12] s390x/css: Add a callback for when subchannel gets disabled Cornelia Huck
2014-11-26 17:28 ` [PATCH RFC v3 09/12] s390x/virtio-ccw: add virtio set-revision call Cornelia Huck
2014-11-26 17:28 ` [PATCH RFC v3 10/12] s390x/virtio-ccw: support virtio-1 set_vq format Cornelia Huck
2014-11-26 17:28 ` Cornelia Huck [this message]
2014-11-26 18:50   ` [PATCH RFC v3 11/12] virtio-net/virtio-blk: enable virtio 1.0 Michael S. Tsirkin
2014-11-27 10:34     ` Cornelia Huck
2014-11-26 17:28 ` [PATCH RFC v3 12/12] s390x/virtio-ccw: " Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1417022923-1654-12-git-send-email-cornelia.huck@de.ibm.com \
    --to=cornelia.huck@de.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rusty@rustcorp.com.au \
    --cc=thuth@linux.vnet.ibm.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox