kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	kvmarm@lists.cs.columbia.edu, christoffer.dall@linaro.org,
	marc.zyngier@arm.com, peter.maydell@linaro.org, agraf@suse.de,
	drjones@redhat.com, pbonzini@redhat.com,
	zhichao.huang@linaro.org
Cc: jan.kiszka@siemens.com, dahi@linux.vnet.ibm.com,
	r65777@freescale.com, bp@suse.de,
	"Alex Bennée" <alex.bennee@linaro.org>
Subject: [PATCH v4 00/12] KVM Guest Debug support for arm64
Date: Fri, 15 May 2015 15:27:03 +0100	[thread overview]
Message-ID: <1431700035-23479-1-git-send-email-alex.bennee@linaro.org> (raw)

Hi,

Here is V4 of the KVM Guest Debug support for arm64.

The changes are all due to Christoffer's review of v3 and sees a few
tweaks. The main change to the debug register code means we no longer
overlay the registers in sys_reg[] context but have specific areas for
the vcpu_debug_state and external_debug_state. As a result the need to
__u64 align the registers has been removed and we now have:

#define KVM_ARM_MAX_DBG_REGS 16
struct kvm_guest_debug_arch {
        __u32 dbg_bcr[KVM_ARM_MAX_DBG_REGS];
        __u64 dbg_bvr[KVM_ARM_MAX_DBG_REGS];
        __u32 dbg_wcr[KVM_ARM_MAX_DBG_REGS];
        __u64 dbg_wvr[KVM_ARM_MAX_DBG_REGS];
};

There are additional comments to clarify how we handle trapping and
preserving registers.

For full details see the changelog on each of the patches.

GIT Repos:

The patches for this series are based off v4.1-rc3 and can be found
at:

https://git.linaro.org/people/alex.bennee/linux.git
branch: guest-debug/4.1-rc3-v4

I'm still in the process of going through the QEMU comments and adding
the re-injection support. However the current working state can be
seen at:

https://github.com/stsquad/qemu
branch: kvm/guest-debug-v4

Alex Bennée (12):
  KVM: add comments for kvm_debug_exit_arch struct
  KVM: define common KVM_GUESTDBG_USE_SW/HW_BP bits
  KVM: arm64: guest debug, define API headers
  KVM: arm: guest debug, add stub KVM_SET_GUEST_DEBUG ioctl
  KVM: arm: introduce kvm_arm_init/setup/clear_debug
  KVM: arm64: guest debug, add SW break point support
  KVM: arm64: guest debug, add support for single-step
  KVM: arm64: re-factor hyp.S debug register code
  KVM: arm64: introduce vcpu->arch.debug_ptr
  KVM: arm64: guest debug, HW assisted debug support
  KVM: arm64: enable KVM_CAP_SET_GUEST_DEBUG
  KVM: arm64: add trace points for guest_debug debug

 Documentation/virtual/kvm/api.txt      |  15 +-
 arch/arm/include/asm/kvm_host.h        |   4 +
 arch/arm/kvm/arm.c                     |  46 ++-
 arch/arm/kvm/trace.h                   |  17 +
 arch/arm64/include/asm/hw_breakpoint.h |  12 +
 arch/arm64/include/asm/kvm_asm.h       |  26 +-
 arch/arm64/include/asm/kvm_host.h      |  30 +-
 arch/arm64/include/uapi/asm/kvm.h      |  18 ++
 arch/arm64/kernel/asm-offsets.c        |   7 +
 arch/arm64/kernel/hw_breakpoint.c      |  12 -
 arch/arm64/kvm/Makefile                |   2 +-
 arch/arm64/kvm/debug.c                 | 203 ++++++++++++
 arch/arm64/kvm/handle_exit.c           |  44 +++
 arch/arm64/kvm/hyp.S                   | 545 ++++++++++-----------------------
 arch/arm64/kvm/reset.c                 |  15 +
 arch/arm64/kvm/sys_regs.c              | 136 ++++++--
 arch/arm64/kvm/trace.h                 | 105 +++++++
 arch/powerpc/include/uapi/asm/kvm.h    |   4 +-
 arch/s390/include/uapi/asm/kvm.h       |   2 -
 arch/x86/include/uapi/asm/kvm.h        |   2 -
 include/uapi/linux/kvm.h               |  11 +-
 21 files changed, 798 insertions(+), 458 deletions(-)
 create mode 100644 arch/arm64/kvm/debug.c

-- 
2.3.5


             reply	other threads:[~2015-05-15 14:26 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-15 14:27 Alex Bennée [this message]
2015-05-15 14:27 ` [PATCH v4 01/12] KVM: add comments for kvm_debug_exit_arch struct Alex Bennée
2015-05-15 14:27 ` [PATCH v4 02/12] KVM: define common KVM_GUESTDBG_USE_SW/HW_BP bits Alex Bennée
2015-05-15 15:42   ` Christian Borntraeger
     [not found]     ` <555613F2.9060204-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>
2015-05-15 17:33       ` David Hildenbrand
2015-05-15 17:46         ` Jan Kiszka
2015-05-15 15:58   ` Christian Borntraeger
2015-05-15 14:27 ` [PATCH v4 03/12] KVM: arm64: guest debug, define API headers Alex Bennée
2015-05-15 14:44   ` Mark Rutland
2015-05-15 15:14     ` Alex Bennée
2015-05-15 15:17       ` Peter Maydell
2015-05-15 15:43         ` Alex Bennée
2015-05-15 15:43         ` Mark Rutland
2015-05-15 16:19           ` Alex Bennée
2015-05-15 14:27 ` [PATCH v4 04/12] KVM: arm: guest debug, add stub KVM_SET_GUEST_DEBUG ioctl Alex Bennée
2015-05-15 14:27 ` [PATCH v4 05/12] KVM: arm: introduce kvm_arm_init/setup/clear_debug Alex Bennée
2015-05-15 14:27 ` [PATCH v4 06/12] KVM: arm64: guest debug, add SW break point support Alex Bennée
2015-05-20  9:17   ` Will Deacon
2015-05-20 12:33     ` Alex Bennée
2015-05-15 14:27 ` [PATCH v4 07/12] KVM: arm64: guest debug, add support for single-step Alex Bennée
2015-05-15 14:27 ` [PATCH v4 08/12] KVM: arm64: re-factor hyp.S debug register code Alex Bennée
2015-05-15 14:27 ` [PATCH v4 09/12] KVM: arm64: introduce vcpu->arch.debug_ptr Alex Bennée
2015-05-15 14:27 ` [PATCH v4 10/12] KVM: arm64: guest debug, HW assisted debug support Alex Bennée
     [not found]   ` <1431700035-23479-11-git-send-email-alex.bennee-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-05-15 15:23     ` Mark Rutland
2015-05-15 16:16       ` Alex Bennée
2015-05-15 17:01         ` Mark Rutland
2015-05-15 17:09         ` Peter Maydell
2015-05-15 14:27 ` [PATCH v4 11/12] KVM: arm64: enable KVM_CAP_SET_GUEST_DEBUG Alex Bennée
2015-05-15 14:27 ` [PATCH v4 12/12] KVM: arm64: add trace points for guest_debug debug Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1431700035-23479-1-git-send-email-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=agraf@suse.de \
    --cc=bp@suse.de \
    --cc=christoffer.dall@linaro.org \
    --cc=dahi@linux.vnet.ibm.com \
    --cc=drjones@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=marc.zyngier@arm.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=r65777@freescale.com \
    --cc=zhichao.huang@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).