From mboxrd@z Thu Jan  1 00:00:00 1970
From: Scott Wood <scottwood@freescale.com>
Subject: Re: [PATCH][RFC] KVM: PPC: fix suspicious use of conditional
 operator
Date: Fri, 22 May 2015 14:20:29 -0500
Message-ID: <1432322429.27761.267.camel@freescale.com>
References: <555F4141.8090107@freescale.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Cc: <kvm-ppc@vger.kernel.org>, Alexander Graf <agraf@suse.de>,
	Laurentiu Tudor <Laurentiu.Tudor@freescale.com>,
	<kvm@vger.kernel.org>,
	"Caraman Mihai Claudiu-B02008" <mihai.caraman@freescale.com>
To: Laurentiu Tudor <b10716@freescale.com>
Return-path: <kvm-ppc-owner@vger.kernel.org>
In-Reply-To: <555F4141.8090107@freescale.com>
Sender: kvm-ppc-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

On Fri, 2015-05-22 at 17:46 +0300, Laurentiu Tudor wrote:
> This was signaled by a static code analysis tool.
> 
> Signed-off-by: Laurentiu Tudor <Laurentiu.Tudor@freescale.com>
> ---
>  arch/powerpc/kvm/e500_mmu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/powerpc/kvm/e500_mmu.c b/arch/powerpc/kvm/e500_mmu.c
> index 50860e9..29911a0 100644
> --- a/arch/powerpc/kvm/e500_mmu.c
> +++ b/arch/powerpc/kvm/e500_mmu.c
> @@ -377,7 +377,7 @@ int kvmppc_e500_emul_tlbsx(struct kvm_vcpu *vcpu, gva_t ea)
>  			| MAS0_NV(vcpu_e500->gtlb_nv[tlbsel]);
>  		vcpu->arch.shared->mas1 =
>  			  (vcpu->arch.shared->mas6 & MAS6_SPID0)
> -			| (vcpu->arch.shared->mas6 & (MAS6_SAS ? MAS1_TS : 0))
> +			| ((vcpu->arch.shared->mas6 & MAS6_SAS) ? MAS1_TS : 0)
>  			| (vcpu->arch.shared->mas4 & MAS4_TSIZED(~0));
>  		vcpu->arch.shared->mas2 &= MAS2_EPN;
>  		vcpu->arch.shared->mas2 |= vcpu->arch.shared->mas4 &

Reviewed-by: Scott Wood <scottwood@freescale.com>

Please send as non-RFC.

-Scott