From mboxrd@z Thu Jan 1 00:00:00 1970 From: Davidlohr Bueso Subject: Re: [PATCH 1/2] KVM: MMU: fix SMAP virtualization Date: Wed, 10 Jun 2015 11:02:46 -0700 Message-ID: <1433959366.3165.87.camel@stgolabs.net> References: <556486F3.5020007@solarflare.com> <556487A6.2020804@redhat.com> <5565318D.1030309@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Paolo Bonzini , Edward Cree , Bandan Das , gleb@kernel.org, mtosatti@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org To: Xiao Guangrong Return-path: Received: from cantor2.suse.de ([195.135.220.15]:34971 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933201AbbFJSCz (ORCPT ); Wed, 10 Jun 2015 14:02:55 -0400 In-Reply-To: <5565318D.1030309@linux.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, 2015-05-27 at 10:53 +0800, Xiao Guangrong wrote: > > On 05/26/2015 10:48 PM, Paolo Bonzini wrote: > > > > > > On 26/05/2015 16:45, Edward Cree wrote: > >>>> This breaks older compilers that can't initialize anon structures. > >>>> > >>>> How old ? Even gcc 3.1 says you can use unnamed struct/union fields and > >>>> 3.2 is the minimum version required to compile the kernel as mentioned > >>>> in the README. > >>>> > >>>> We could simply just name the structure, but I doubt this is the > >>>> only place in the kernel code where it's being used this way :) > >> This appears to be GCC bug #10676, see > >> Says it was fixed in 4.6, but I believe the kernel supports GCCs much older > >> than that (back to 3.2). I personally hit it on 4.4.7, the version shipped > >> with RHEL6.6. > > > > Yes, it will be fixed soon(ish). Probably before you can get rid of the > > obnoxious disclaimer... :) > > It has been fixed by Andrew: > > From: Andrew Morton > Subject: arch/x86/kvm/mmu.c: work around gcc-4.4.4 bug Folks, this fix is missing in both -tip and Linus' (4.1-rc7) tree. At least I'm running into it. Thanks, Davidlohr