From: Andreas Herrmann <andreas.herrmann@caviumnetworks.com>
To: Will Deacon <will.deacon@arm.com>
Cc: <kvm@vger.kernel.org>,
Andreas Herrmann <andreas.herrmann@caviumnetworks.com>
Subject: [PATCH 2/5] kvmtool: Fix regression introduced with d2a7ddff4
Date: Mon, 15 Jun 2015 13:49:43 +0200 [thread overview]
Message-ID: <1434368986-14963-3-git-send-email-andreas.herrmann@caviumnetworks.com> (raw)
In-Reply-To: <1434368986-14963-1-git-send-email-andreas.herrmann@caviumnetworks.com>
Since commit d2a7ddff4 (Add minimal support for macvtap) opening
of tap device might fail. lkvm shows
Warning: Config tap device error. Are you root?
virtio_net_request_tap passed wrong pointer for struct ifreq to
TUNSETIFF ioctl.
Signed-off-by: Andreas Herrmann <andreas.herrmann@caviumnetworks.com>
---
virtio/net.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/virtio/net.c b/virtio/net.c
index d59a0d5..122a9e2 100644
--- a/virtio/net.c
+++ b/virtio/net.c
@@ -287,7 +287,7 @@ static int virtio_net_request_tap(struct net_dev *ndev, struct ifreq *ifr,
if (tapname)
strncpy(ifr->ifr_name, tapname, sizeof(ifr->ifr_name));
- ret = ioctl(ndev->tap_fd, TUNSETIFF, &ifr);
+ ret = ioctl(ndev->tap_fd, TUNSETIFF, ifr);
if (ret >= 0)
strncpy(ndev->tap_name, ifr->ifr_name, sizeof(ndev->tap_name));
--
1.7.9.5
next prev parent reply other threads:[~2015-06-15 12:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-15 11:49 [PATCH 0/5] kvmtool: Misc fixes Andreas Herrmann
2015-06-15 11:49 ` [PATCH 1/5] kvmtool: Fix compile error on MIPS Andreas Herrmann
2015-06-15 11:49 ` Andreas Herrmann [this message]
2015-06-15 11:49 ` [PATCH 3/5] kvmtool: Register each guest memory bank as vhost_memory_region Andreas Herrmann
2015-06-15 11:49 ` [PATCH 4/5] kvmtool: Save datamatch as little endian in {add,del}_event Andreas Herrmann
2015-06-16 17:17 ` Will Deacon
2015-06-17 7:17 ` Andreas Herrmann
2015-06-17 10:03 ` Will Deacon
2015-06-15 11:49 ` [PATCH 5/5] kvmtool: Fix length of ioevent for VIRTIO_PCI_QUEUE_NOTIFY Andreas Herrmann
2015-06-16 17:29 ` [PATCH 0/5] kvmtool: Misc fixes Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434368986-14963-3-git-send-email-andreas.herrmann@caviumnetworks.com \
--to=andreas.herrmann@caviumnetworks.com \
--cc=kvm@vger.kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox