From: Ben Hutchings <ben@decadent.org.uk>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Pavel Fedin <p.fedin@samsung.com>
Cc: "kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>,
KVM devel mailing list <kvm@vger.kernel.org>,
Marc Zyngier <marc.zyngier@arm.com>,
Christoffer Dall <christoffer.dall@linaro.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH] KVM: arm/arm64: Revert to old way of checking for device mapping in stage2_flush_ptes().
Date: Fri, 04 Dec 2015 01:58:57 +0000 [thread overview]
Message-ID: <1449194337.30642.69.camel@decadent.org.uk> (raw)
In-Reply-To: <CAKv+Gu-WhtTZoPEmRSa8Ypcc9SZ-d6NABDSfZ6tTx14Tyt+AdQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 978 bytes --]
On Wed, 2015-12-02 at 18:41 +0100, Ard Biesheuvel wrote:
> Hi Pavel,
>
> Thanks for getting to the bottom of this.
>
> On 1 December 2015 at 14:03, Pavel Fedin <p.fedin@samsung.com> wrote:
> > This function takes stage-II physical addresses (A.K.A. IPA), on input, not
> > real physical addresses. This causes kvm_is_device_pfn() to return wrong
> > values, depending on how much guest and host memory maps match. This
> > results in completely broken KVM on some boards. The problem has been
> > caught on Samsung proprietary hardware.
> >
> > Cc: stable@vger.kernel.org
> > Fixes: e6fab5442345 ("ARM/arm64: KVM: test properly for a PTE's uncachedness")
> >
>
> That commit is not in a release yet, so no need for cc stable
[...]
But it is cc'd to stable, so unless it is going to be nacked at review
stage, any subsequent fixes should also be cc'd.
Ben.
--
Ben Hutchings
For every action, there is an equal and opposite criticism. - Harrison
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 811 bytes --]
next prev parent reply other threads:[~2015-12-04 1:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-01 13:03 [PATCH] KVM: arm/arm64: Revert to old way of checking for device mapping in stage2_flush_ptes() Pavel Fedin
2015-12-02 17:41 ` Ard Biesheuvel
2015-12-03 7:14 ` Pavel Fedin
2015-12-03 8:09 ` Ard Biesheuvel
2015-12-03 8:14 ` Pavel Fedin
2015-12-04 1:58 ` Ben Hutchings [this message]
2015-12-04 6:39 ` Pavel Fedin
2015-12-04 8:37 ` Ard Biesheuvel
2015-12-02 18:50 ` Christoffer Dall
2015-12-02 19:04 ` Ard Biesheuvel
2015-12-02 19:23 ` Christoffer Dall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1449194337.30642.69.camel@decadent.org.uk \
--to=ben@decadent.org.uk \
--cc=ard.biesheuvel@linaro.org \
--cc=christoffer.dall@linaro.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=marc.zyngier@arm.com \
--cc=p.fedin@samsung.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox