kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bruce Rogers <brogers@suse.com>
To: kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: jan.kiszka@siemens.com, namit@cs.technion.ac.il,
	Bruce Rogers <brogers@suse.com>
Subject: [PATCH 1/2] KVM: x86: fix ordering of cr0 initialization code in vmx_cpu_reset
Date: Wed,  3 Feb 2016 15:51:15 -0700	[thread overview]
Message-ID: <1454539876-8310-1-git-send-email-brogers@suse.com> (raw)

Commit d28bc9dd25ce reversed the order of two lines which initialize cr0,
allowing the current (old) cr0 value to mess up vcpu initialization.
This was observed in the checks for cr0 X86_CR0_WP bit in the context of
kvm_mmu_reset_context().  Besides, setting vcpu->arch.cr0 after vmx_set_cr0()
is completely redundant. Change the order back to ensure proper vcpu
intiialization.

Signed-off-by: Bruce Rogers <brogers@suse.com>
---
 arch/x86/kvm/vmx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
index e2951b6..21507b4 100644
--- a/arch/x86/kvm/vmx.c
+++ b/arch/x86/kvm/vmx.c
@@ -4993,8 +4993,8 @@ static void vmx_vcpu_reset(struct kvm_vcpu *vcpu, bool init_event)
 		vmcs_write16(VIRTUAL_PROCESSOR_ID, vmx->vpid);
 
 	cr0 = X86_CR0_NW | X86_CR0_CD | X86_CR0_ET;
-	vmx_set_cr0(vcpu, cr0); /* enter rmode */
 	vmx->vcpu.arch.cr0 = cr0;
+	vmx_set_cr0(vcpu, cr0); /* enter rmode */
 	vmx_set_cr4(vcpu, 0);
 	vmx_set_efer(vcpu, 0);
 	vmx_fpu_activate(vcpu);
-- 
1.9.0

             reply	other threads:[~2016-02-03 22:51 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-03 22:51 Bruce Rogers [this message]
2016-02-03 22:51 ` [PATCH 2/2] KVM: x86: allow BSP to handle INIT IPIs like APs do Bruce Rogers
2016-02-08 15:12   ` Paolo Bonzini
2016-02-08 15:22     ` Jan Kiszka
2016-02-08 16:33       ` Bruce Rogers
2016-02-08 16:40         ` Paolo Bonzini
2016-02-08 17:27           ` Bruce Rogers
2016-02-08 17:44             ` Paolo Bonzini
2016-02-08 17:38           ` Bruce Rogers
2016-02-08 17:53             ` Jan Kiszka
2016-02-10 17:24               ` Bruce Rogers
2016-02-03 23:18 ` [PATCH 1/2] KVM: x86: fix ordering of cr0 initialization code in vmx_cpu_reset Nadav Amit
2016-02-03 23:38   ` Bruce Rogers
2016-04-22 18:55   ` Bruce Rogers
2016-02-08 15:09 ` Paolo Bonzini
2016-02-08 16:29   ` Bruce Rogers
2016-02-08 16:43     ` Paolo Bonzini
2016-04-27  2:54     ` Wanpeng Li
2016-04-28 22:18       ` Bruce Rogers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1454539876-8310-1-git-send-email-brogers@suse.com \
    --to=brogers@suse.com \
    --cc=jan.kiszka@siemens.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namit@cs.technion.ac.il \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).