From: Bruce Rogers <brogers@suse.com>
To: kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: jan.kiszka@siemens.com, namit@cs.technion.ac.il,
Bruce Rogers <brogers@suse.com>
Subject: [PATCH 2/2] KVM: x86: allow BSP to handle INIT IPIs like APs do
Date: Wed, 3 Feb 2016 15:51:16 -0700 [thread overview]
Message-ID: <1454539876-8310-2-git-send-email-brogers@suse.com> (raw)
In-Reply-To: <1454539876-8310-1-git-send-email-brogers@suse.com>
The INIT IPI event handler special cases the boot-strap processor
(BSP) handling, avoiding the same mp state handling which is done for
the other (AP) processors. Debugging a linux guest usage scenario of
avoiding a reboot through the bios for a crash on any processor via eg:
kexec -p /boot/vmlinuz --initrd=/boot/initrd --append="$(cat /proc/cmdline)\
maxcpus=1" led to identifying this change as the needed fix.
With this change, an AP can now startup the BSP without error.
Signed-off-by: Bruce Rogers <brogers@suse.com>
---
arch/x86/kvm/lapic.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c
index 36591fa..eda6bfb 100644
--- a/arch/x86/kvm/lapic.c
+++ b/arch/x86/kvm/lapic.c
@@ -2170,10 +2170,7 @@ void kvm_apic_accept_events(struct kvm_vcpu *vcpu)
if (test_bit(KVM_APIC_INIT, &pe)) {
kvm_lapic_reset(vcpu, true);
kvm_vcpu_reset(vcpu, true);
- if (kvm_vcpu_is_bsp(apic->vcpu))
- vcpu->arch.mp_state = KVM_MP_STATE_RUNNABLE;
- else
- vcpu->arch.mp_state = KVM_MP_STATE_INIT_RECEIVED;
+ vcpu->arch.mp_state = KVM_MP_STATE_INIT_RECEIVED;
}
if (test_bit(KVM_APIC_SIPI, &pe) &&
vcpu->arch.mp_state == KVM_MP_STATE_INIT_RECEIVED) {
--
1.9.0
next prev parent reply other threads:[~2016-02-03 22:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-03 22:51 [PATCH 1/2] KVM: x86: fix ordering of cr0 initialization code in vmx_cpu_reset Bruce Rogers
2016-02-03 22:51 ` Bruce Rogers [this message]
2016-02-08 15:12 ` [PATCH 2/2] KVM: x86: allow BSP to handle INIT IPIs like APs do Paolo Bonzini
2016-02-08 15:22 ` Jan Kiszka
2016-02-08 16:33 ` Bruce Rogers
2016-02-08 16:40 ` Paolo Bonzini
2016-02-08 17:27 ` Bruce Rogers
2016-02-08 17:44 ` Paolo Bonzini
2016-02-08 17:38 ` Bruce Rogers
2016-02-08 17:53 ` Jan Kiszka
2016-02-10 17:24 ` Bruce Rogers
2016-02-03 23:18 ` [PATCH 1/2] KVM: x86: fix ordering of cr0 initialization code in vmx_cpu_reset Nadav Amit
2016-02-03 23:38 ` Bruce Rogers
2016-04-22 18:55 ` Bruce Rogers
2016-02-08 15:09 ` Paolo Bonzini
2016-02-08 16:29 ` Bruce Rogers
2016-02-08 16:43 ` Paolo Bonzini
2016-04-27 2:54 ` Wanpeng Li
2016-04-28 22:18 ` Bruce Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454539876-8310-2-git-send-email-brogers@suse.com \
--to=brogers@suse.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namit@cs.technion.ac.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).