From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?q?Radim=20Kr=C4=8Dm=C3=A1=C5=99?= Subject: [PATCH v2 11/14] KVM: x86: remove pit and kvm from kvm_kpit_state Date: Wed, 17 Feb 2016 20:14:53 +0100 Message-ID: <1455736496-374-12-git-send-email-rkrcmar@redhat.com> References: <1455736496-374-1-git-send-email-rkrcmar@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: kvm@vger.kernel.org, Paolo Bonzini , Yuki Shibuya To: linux-kernel@vger.kernel.org Return-path: In-Reply-To: <1455736496-374-1-git-send-email-rkrcmar@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org kvm isn't ever used and pit can be accessed with container_of. If you *really* need kvm, pit_state_to_pit(ps)->kvm. Signed-off-by: Radim Kr=C4=8Dm=C3=A1=C5=99 --- v2: new arch/x86/kvm/i8254.c | 14 +++++++++----- arch/x86/kvm/i8254.h | 2 -- 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/arch/x86/kvm/i8254.c b/arch/x86/kvm/i8254.c index 28ad45abf386..d09925e7934a 100644 --- a/arch/x86/kvm/i8254.c +++ b/arch/x86/kvm/i8254.c @@ -215,10 +215,16 @@ static void pit_latch_status(struct kvm_pit *pit,= int channel) } } =20 +static inline struct kvm_pit *pit_state_to_pit(struct kvm_kpit_state *= ps) +{ + return container_of(ps, struct kvm_pit, pit_state); +} + static void kvm_pit_ack_irq(struct kvm_irq_ack_notifier *kian) { struct kvm_kpit_state *ps =3D container_of(kian, struct kvm_kpit_stat= e, irq_ack_notifier); + struct kvm_pit *pit =3D pit_state_to_pit(ps); =20 atomic_set(&ps->irq_ack, 1); /* irq_ack should be set before pending is read. Order accesses with @@ -226,7 +232,7 @@ static void kvm_pit_ack_irq(struct kvm_irq_ack_noti= fier *kian) */ smp_mb(); if (atomic_dec_if_positive(&ps->pending) > 0) - queue_kthread_work(&ps->pit->worker, &ps->pit->expired); + queue_kthread_work(&pit->worker, &pit->expired); } =20 void __kvm_migrate_pit_timer(struct kvm_vcpu *vcpu) @@ -281,7 +287,7 @@ static void pit_do_work(struct kthread_work *work) static enum hrtimer_restart pit_timer_fn(struct hrtimer *data) { struct kvm_kpit_state *ps =3D container_of(data, struct kvm_kpit_stat= e, timer); - struct kvm_pit *pt =3D ps->kvm->arch.vpit; + struct kvm_pit *pt =3D pit_state_to_pit(ps); =20 if (ps->reinject) atomic_inc(&ps->pending); @@ -338,12 +344,11 @@ static void create_pit_timer(struct kvm_pit *pit,= u32 val, int is_period) =20 /* TODO The new value only affected after the retriggered */ hrtimer_cancel(&ps->timer); - flush_kthread_work(&ps->pit->expired); + flush_kthread_work(&pit->expired); ps->period =3D interval; ps->is_periodic =3D is_period; =20 ps->timer.function =3D pit_timer_fn; - ps->kvm =3D pit->kvm; =20 kvm_pit_reset_reinject(pit); =20 @@ -696,7 +701,6 @@ struct kvm_pit *kvm_create_pit(struct kvm *kvm, u32= flags) pit->kvm =3D kvm; =20 pit_state =3D &pit->pit_state; - pit_state->pit =3D pit; hrtimer_init(&pit_state->timer, CLOCK_MONOTONIC, HRTIMER_MODE_ABS); =20 pit_state->irq_ack_notifier.gsi =3D 0; diff --git a/arch/x86/kvm/i8254.h b/arch/x86/kvm/i8254.h index 47a96e803aab..2f11f5e55021 100644 --- a/arch/x86/kvm/i8254.h +++ b/arch/x86/kvm/i8254.h @@ -32,8 +32,6 @@ struct kvm_kpit_state { u32 speaker_data_on; =20 struct mutex lock; - struct kvm *kvm; - struct kvm_pit *pit; atomic_t pending; /* accumulated triggered timers */ atomic_t irq_ack; struct kvm_irq_ack_notifier irq_ack_notifier; --=20 2.7.1