From: Peter Feiner <pfeiner@google.com>
To: kvm@vger.kernel.org, drjones@redhat.com, pbonzini@redhat.com
Cc: pfeiner@google.com
Subject: [kvm-unit-tests PATCH] x86: vmx: actually allocate io_bitmap_b
Date: Mon, 22 Feb 2016 15:35:00 -0800 [thread overview]
Message-ID: <1456184100-30323-1-git-send-email-pfeiner@google.com> (raw)
Test would run and pass with io_bitmap_b = 0.
I discovered the problem while developing a new test. I expected to
get an 'Unhandled cpu exception 14' message but the test VM rebooted
instead. I suspect it hit a triple fault but I didn't debug further.
Signed-off-by: Peter Feiner <pfeiner@google.com>
---
x86/vmx_tests.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/x86/vmx_tests.c b/x86/vmx_tests.c
index 451fdd7..bb65c06 100644
--- a/x86/vmx_tests.c
+++ b/x86/vmx_tests.c
@@ -566,7 +566,7 @@ static int iobmp_init()
u32 ctrl_cpu0;
io_bitmap_a = alloc_page();
- io_bitmap_a = alloc_page();
+ io_bitmap_b = alloc_page();
memset(io_bitmap_a, 0x0, PAGE_SIZE);
memset(io_bitmap_b, 0x0, PAGE_SIZE);
ctrl_cpu0 = vmcs_read(CPU_EXEC_CTRL0);
--
2.7.0.rc3.207.g0ac5344
reply other threads:[~2016-02-22 23:35 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456184100-30323-1-git-send-email-pfeiner@google.com \
--to=pfeiner@google.com \
--cc=drjones@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).