public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Feiner <pfeiner@google.com>
To: kvm@vger.kernel.org, jan.kiszka@siemens.com, drjones@redhat.com,
	pbonzini@redhat.com
Cc: pfeiner@google.com
Subject: [kvm-unit-tests v2 3/6] x86: vmx: Named constant: EPT_ADDR_MASK
Date: Tue,  1 Mar 2016 14:34:51 -0800	[thread overview]
Message-ID: <1456871694-23042-4-git-send-email-pfeiner@google.com> (raw)
In-Reply-To: <1456871694-23042-1-git-send-email-pfeiner@google.com>

Signed-off-by: Peter Feiner <pfeiner@google.com>
---
 x86/vmx.c | 6 +++---
 x86/vmx.h | 2 ++
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/x86/vmx.c b/x86/vmx.c
index 3fa1a73..9811a28 100644
--- a/x86/vmx.c
+++ b/x86/vmx.c
@@ -246,7 +246,7 @@ void install_ept_entry(unsigned long *pml4,
 					| EPT_RA | EPT_WA | EPT_EA;
 		} else
 			pt[offset] &= ~EPT_LARGE_PAGE;
-		pt = phys_to_virt(pt[offset] & 0xffffffffff000ull);
+		pt = phys_to_virt(pt[offset] & EPT_ADDR_MASK);
 	}
 	offset = ((unsigned long)guest_addr >> ((level-1) *
 			EPT_PGDIR_WIDTH + 12)) & EPT_PGDIR_MASK;
@@ -334,7 +334,7 @@ unsigned long get_ept_pte(unsigned long *pml4,
 			break;
 		if (l < 4 && (pte & EPT_LARGE_PAGE))
 			return pte;
-		pt = (unsigned long *)(pte & 0xffffffffff000ull);
+		pt = (unsigned long *)(pte & EPT_ADDR_MASK);
 	}
 	offset = (guest_addr >> (((l-1) * EPT_PGDIR_WIDTH) + 12))
 			& EPT_PGDIR_MASK;
@@ -378,7 +378,7 @@ int set_ept_pte(unsigned long *pml4, unsigned long guest_addr,
 			break;
 		if (!(pt[offset] & (EPT_PRESENT)))
 			return -1;
-		pt = (unsigned long *)(pt[offset] & 0xffffffffff000ull);
+		pt = (unsigned long *)(pt[offset] & EPT_ADDR_MASK);
 	}
 	offset = (guest_addr >> (((l-1) * EPT_PGDIR_WIDTH) + 12))
 			& EPT_PGDIR_MASK;
diff --git a/x86/vmx.h b/x86/vmx.h
index 8b79191..616ffc0 100644
--- a/x86/vmx.h
+++ b/x86/vmx.h
@@ -3,6 +3,7 @@
 
 #include "libcflat.h"
 #include "processor.h"
+#include "bitops.h"
 
 struct vmcs {
 	u32 revision_id; /* vmcs revision identifier */
@@ -466,6 +467,7 @@ enum Ctrl1 {
 #define EPT_PAGE_LEVEL		4
 #define EPT_PGDIR_WIDTH		9
 #define EPT_PGDIR_MASK		511
+#define EPT_ADDR_MASK		GENMASK(52, 11)
 #define PAGE_MASK		(~(PAGE_SIZE-1))
 #define PAGE_MASK_2M		(~(PAGE_SIZE_2M-1))
 
-- 
2.7.0.rc3.207.g0ac5344


  parent reply	other threads:[~2016-03-01 22:35 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-01 19:30 [kvm-unit-tests 0/5] Split large EPT mappings properly Peter Feiner
2016-03-01 19:30 ` [kvm-unit-tests 1/5] x86: vmx.h: trivial whitespace fixes Peter Feiner
2016-03-01 19:30 ` [kvm-unit-tests 2/5] x86: vmx: Named constant: EPT_ADDR_MASK Peter Feiner
2016-03-01 21:12   ` Paolo Bonzini
2016-03-01 21:16     ` Peter Feiner
2016-03-01 21:27       ` Jan Kiszka
2016-03-01 21:36         ` Paolo Bonzini
2016-03-01 19:30 ` [kvm-unit-tests 3/5] x86: vmx: Named constant: EPT_LEVEL_SHIFT Peter Feiner
2016-03-01 19:30 ` [kvm-unit-tests 4/5] x86: vmx: split large EPTEs in install_ept_entry Peter Feiner
2016-03-01 19:30 ` [kvm-unit-tests 5/5] x86: vmx: don't explicitly split identity EPT map Peter Feiner
2016-03-01 21:13 ` [kvm-unit-tests 0/5] Split large EPT mappings properly Paolo Bonzini
2016-03-01 22:34 ` [kvm-unit-tests v2 0/6] " Peter Feiner
2016-03-01 22:34   ` [kvm-unit-tests v2 1/6] x86: vmx.h: trivial whitespace fixes Peter Feiner
2016-03-01 22:34   ` [kvm-unit-tests v2 2/6] lib: generic bitops.h Peter Feiner
2016-03-01 22:34   ` Peter Feiner [this message]
2016-03-02  6:24     ` [kvm-unit-tests v2 3/6] x86: vmx: Named constant: EPT_ADDR_MASK Jan Kiszka
2016-03-02  8:47       ` Paolo Bonzini
2016-03-02 16:50         ` Peter Feiner
2016-03-01 22:34   ` [kvm-unit-tests v2 4/6] x86: vmx: Named constant: EPT_LEVEL_SHIFT Peter Feiner
2016-03-01 22:34   ` [kvm-unit-tests v2 5/6] x86: vmx: split large EPTEs in install_ept_entry Peter Feiner
2016-03-01 22:34   ` [kvm-unit-tests v2 6/6] x86: vmx: don't explicitly split identity EPT map Peter Feiner
2016-03-02 17:10 ` [kvm-unit-tests v3 0/6] Split large EPT mappings properly Peter Feiner
2016-03-02 17:10   ` [kvm-unit-tests v3 1/6] x86: vmx.h: trivial whitespace fixes Peter Feiner
2016-03-02 17:10   ` [kvm-unit-tests v3 2/6] lib: generic bitops.h Peter Feiner
2016-03-02 18:13     ` Andrew Jones
2016-03-02 17:10   ` [kvm-unit-tests v3 3/6] x86: vmx: Named constant: EPT_ADDR_MASK Peter Feiner
2016-03-02 17:10   ` [kvm-unit-tests v3 4/6] x86: vmx: Named constant: EPT_LEVEL_SHIFT Peter Feiner
2016-03-02 17:10   ` [kvm-unit-tests v3 5/6] x86: vmx: split large EPTEs in install_ept_entry Peter Feiner
2016-03-02 17:10   ` [kvm-unit-tests v3 6/6] x86: vmx: don't explicitly split identity EPT map Peter Feiner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1456871694-23042-4-git-send-email-pfeiner@google.com \
    --to=pfeiner@google.com \
    --cc=drjones@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox