From: Peter Feiner <pfeiner@google.com>
To: kvm@vger.kernel.org, jan.kiszka@siemens.com, drjones@redhat.com,
pbonzini@redhat.com
Cc: pfeiner@google.com
Subject: [kvm-unit-tests v3 0/6] Split large EPT mappings properly
Date: Wed, 2 Mar 2016 09:10:51 -0800 [thread overview]
Message-ID: <1456938657-20850-1-git-send-email-pfeiner@google.com> (raw)
In-Reply-To: <1456860622-31251-1-git-send-email-pfeiner@google.com>
install_ept_entry would overwrite arbitrary memory when it encountered
a large page.
I discovered the bug while working on a simple multi-page allocator,
which I'm using for huge page testing, that sorts the free list in
ascending order of HPA.
v3:
* Added #define BITS_PER_LONG_LONG 64
* Fixed EPT_ADDR_MASK bit range
* Made EPT_ADDR_MASK unsigned long long
v2:
* Added lib/bitops.h for GENMASK.
* Factored common stuff out of lib/*/asm/bitops.h
* Fixed all of the whitespace in vmx.h.
Peter Feiner (6):
x86: vmx.h: trivial whitespace fixes
lib: generic bitops.h
x86: vmx: Named constant: EPT_ADDR_MASK
x86: vmx: Named constant: EPT_LEVEL_SHIFT
x86: vmx: split large EPTEs in install_ept_entry
x86: vmx: don't explicitly split identity EPT map
lib/arm/asm/bitops.h | 8 ++--
lib/arm/asm/cpumask.h | 2 +-
lib/arm/bitops.c | 2 +-
lib/arm64/asm/bitops.h | 8 ++--
lib/bitops.h | 36 ++++++++++++++++
lib/ppc64/asm/bitops.h | 10 +++++
lib/x86/asm/bitops.h | 14 +++++++
x86/vmx.c | 65 ++++++++++++++++++++++-------
x86/vmx.h | 111 +++++++++++++++++++++++++------------------------
x86/vmx_tests.c | 7 ----
10 files changed, 176 insertions(+), 87 deletions(-)
create mode 100644 lib/bitops.h
create mode 100644 lib/ppc64/asm/bitops.h
create mode 100644 lib/x86/asm/bitops.h
--
2.7.0.rc3.207.g0ac5344
next prev parent reply other threads:[~2016-03-02 17:11 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 19:30 [kvm-unit-tests 0/5] Split large EPT mappings properly Peter Feiner
2016-03-01 19:30 ` [kvm-unit-tests 1/5] x86: vmx.h: trivial whitespace fixes Peter Feiner
2016-03-01 19:30 ` [kvm-unit-tests 2/5] x86: vmx: Named constant: EPT_ADDR_MASK Peter Feiner
2016-03-01 21:12 ` Paolo Bonzini
2016-03-01 21:16 ` Peter Feiner
2016-03-01 21:27 ` Jan Kiszka
2016-03-01 21:36 ` Paolo Bonzini
2016-03-01 19:30 ` [kvm-unit-tests 3/5] x86: vmx: Named constant: EPT_LEVEL_SHIFT Peter Feiner
2016-03-01 19:30 ` [kvm-unit-tests 4/5] x86: vmx: split large EPTEs in install_ept_entry Peter Feiner
2016-03-01 19:30 ` [kvm-unit-tests 5/5] x86: vmx: don't explicitly split identity EPT map Peter Feiner
2016-03-01 21:13 ` [kvm-unit-tests 0/5] Split large EPT mappings properly Paolo Bonzini
2016-03-01 22:34 ` [kvm-unit-tests v2 0/6] " Peter Feiner
2016-03-01 22:34 ` [kvm-unit-tests v2 1/6] x86: vmx.h: trivial whitespace fixes Peter Feiner
2016-03-01 22:34 ` [kvm-unit-tests v2 2/6] lib: generic bitops.h Peter Feiner
2016-03-01 22:34 ` [kvm-unit-tests v2 3/6] x86: vmx: Named constant: EPT_ADDR_MASK Peter Feiner
2016-03-02 6:24 ` Jan Kiszka
2016-03-02 8:47 ` Paolo Bonzini
2016-03-02 16:50 ` Peter Feiner
2016-03-01 22:34 ` [kvm-unit-tests v2 4/6] x86: vmx: Named constant: EPT_LEVEL_SHIFT Peter Feiner
2016-03-01 22:34 ` [kvm-unit-tests v2 5/6] x86: vmx: split large EPTEs in install_ept_entry Peter Feiner
2016-03-01 22:34 ` [kvm-unit-tests v2 6/6] x86: vmx: don't explicitly split identity EPT map Peter Feiner
2016-03-02 17:10 ` Peter Feiner [this message]
2016-03-02 17:10 ` [kvm-unit-tests v3 1/6] x86: vmx.h: trivial whitespace fixes Peter Feiner
2016-03-02 17:10 ` [kvm-unit-tests v3 2/6] lib: generic bitops.h Peter Feiner
2016-03-02 18:13 ` Andrew Jones
2016-03-02 17:10 ` [kvm-unit-tests v3 3/6] x86: vmx: Named constant: EPT_ADDR_MASK Peter Feiner
2016-03-02 17:10 ` [kvm-unit-tests v3 4/6] x86: vmx: Named constant: EPT_LEVEL_SHIFT Peter Feiner
2016-03-02 17:10 ` [kvm-unit-tests v3 5/6] x86: vmx: split large EPTEs in install_ept_entry Peter Feiner
2016-03-02 17:10 ` [kvm-unit-tests v3 6/6] x86: vmx: don't explicitly split identity EPT map Peter Feiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456938657-20850-1-git-send-email-pfeiner@google.com \
--to=pfeiner@google.com \
--cc=drjones@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox