Re: [kvm-unit-tests PATCH 2/2] powerpc/ppc64: Makefile cleanup

Thomas Huth
2016-05-10T06:19:39Z

On 09.05.2016 16:01, Andrew Jones wrote:
> This does the same cleanup as 'x86: Makefile refine'
>
> Signed-off-by: Andrew Jones <drjones@redhat.com>
> ---
> powerpc/Makefile.common | 13 ++++---------
> 1 file changed, 4 insertions(+), 9 deletions(-)
>
> diff --git a/powerpc/Makefile.common b/powerpc/Makefile.common
> index 4449aec616853..60d545c98e38c 100644
> --- a/powerpc/Makefile.common
> +++ b/powerpc/Makefile.common
> @@ -22,6 +22,9 @@ CFLAGS += -I lib -I lib/libfdt
> CFLAGS += -Wa,-mregnames
> CFLAGS += -fpie
>
> +# We want to keep intermediate files: %.elf and %.o
> +.PRECIOUS: %.elf %.o

If you just want to keep intermediate files, wouldn't it be better to
use .SECONDARY instead of .PRECIOUS? .PRECIOUS seems to contain some
more magic that comes into action when make is killed by a signal... not
sure if we want to have that here?

Thomas