Re: [PATCH v6 6/8] vfio/pci: Intel graphics legacy mode assignment

Gerd Hoffmann
2016-05-18T14:22:01Z

On Di, 2016-05-17 at 14:19 -0600, Alex Williamson wrote:
> +static int igd_gen(VFIOPCIDevice *vdev)
> +{
> + if ((vdev->device_id & 0xfff) == 0xa84) {
> + return 8; /* Broxton */
> + }
> +
> + switch (vdev->device_id & 0xff00) {
> + /* Old, untested, unavailable, unknown */
> + case 0x0000:
> + case 0x2500:
> + case 0x2700:
> + case 0x2900:
> + case 0x2a00:
> + case 0x2e00:
> + case 0x3500:
> + case 0xa000:
> + return -1;
> + /* SandyBridge, IvyBridge, ValleyView, Haswell */
> + case 0x0100:
> + case 0x0400:
> + case 0x0a00:
> + case 0x0c00:
> + case 0x0d00:
> + case 0x0f00:
> + return 6;
> + /* BroadWell, CherryView, SkyLake, KabyLake */
> + case 0x1600:
> + case 0x1900:
> + case 0x2200:
> + case 0x5900:
> + return 8;
> + }
> +
> + return 8; /* Assume newer is compatible */
> +}
> +

This link:
https://github.com/01org/Igvtg-qemu/commit/ea32e6769004d6eb98d2dbd859d81bf1885c6ad2#diff-9d4d99332b83a7de33cbeed489d60448R920

happened to land in my inbox these days. It provides a bunch of
functions called is_$codename() and intel_gen_version(). Looks more
complete to me. Maybe we should pick up them and find a place in the
qemu source tree where both vfio and intel-vgpu (and maybe xen device
assignment too) can share those functions?

cheers,
Gerd