public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Bandan Das <bsd@redhat.com>
To: kvm@vger.kernel.org
Cc: pbonzini@redhat.com, guangrong.xiao@linux.intel.com,
	linux-kernel@vger.kernel.org
Subject: [PATCH 2/5] mmu: pass execonly value when initializing rsvd bits
Date: Tue, 28 Jun 2016 00:32:37 -0400	[thread overview]
Message-ID: <1467088360-10186-3-git-send-email-bsd@redhat.com> (raw)
In-Reply-To: <1467088360-10186-1-git-send-email-bsd@redhat.com>

In reset_tdp_shadow_zero_bits_mask, we always pass false
when initializing the reserved bits. By initializing with the
correct value of ept exec only, the host can correctly
identify if the guest pte is valid. Note that
kvm_init_shadow_ept_mmu() already knows about execonly.

Signed-off-by: Bandan Das <bsd@redhat.com>
---
 arch/x86/kvm/mmu.c | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
index a50af79..875d4f7 100644
--- a/arch/x86/kvm/mmu.c
+++ b/arch/x86/kvm/mmu.c
@@ -3831,23 +3831,27 @@ static inline bool boot_cpu_is_amd(void)
 
 /*
  * the direct page table on host, use as much mmu features as
- * possible, however, kvm currently does not do execution-protection.
+ * possible
  */
 static void
 reset_tdp_shadow_zero_bits_mask(struct kvm_vcpu *vcpu,
 				struct kvm_mmu *context)
 {
+	bool execonly;
+
 	if (boot_cpu_is_amd())
 		__reset_rsvds_bits_mask(vcpu, &context->shadow_zero_check,
 					boot_cpu_data.x86_phys_bits,
 					context->shadow_root_level, false,
 					boot_cpu_has(X86_FEATURE_GBPAGES),
 					true, true);
-	else
+	else {
+		execonly = !(context->guest_rsvd_check.bad_mt_xwr &
+			     (1ull << VMX_EPT_EXECUTABLE_MASK));
 		__reset_rsvds_bits_mask_ept(&context->shadow_zero_check,
 					    boot_cpu_data.x86_phys_bits,
-					    false);
-
+					    execonly);
+	}
 }
 
 /*
-- 
2.5.5


  parent reply	other threads:[~2016-06-28  4:34 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-28  4:32 [PATCH 0/5] Add support for EPT execute only for nested hypervisors Bandan Das
2016-06-28  4:32 ` [PATCH 1/5] mmu: mark spte present if the x bit is set Bandan Das
2016-06-28  8:44   ` Paolo Bonzini
2016-06-28 17:33     ` Bandan Das
2016-06-28 20:17       ` Paolo Bonzini
2016-06-28 20:37         ` Bandan Das
2016-06-28 20:49           ` Paolo Bonzini
2016-06-28 21:04             ` Bandan Das
2016-06-29  3:01             ` Xiao Guangrong
2016-07-05  3:06             ` Wanpeng Li
2016-07-05 10:50               ` Paolo Bonzini
2016-07-05 11:29                 ` Wanpeng Li
2016-06-28  4:32 ` Bandan Das [this message]
2016-06-29  3:07   ` [PATCH 2/5] mmu: pass execonly value when initializing rsvd bits Xiao Guangrong
2016-06-28  4:32 ` [PATCH 3/5] mmu: don't set the present bit unconditionally Bandan Das
2016-06-28  8:57   ` Paolo Bonzini
2016-06-28 17:30     ` Bandan Das
2016-06-28 20:21       ` Paolo Bonzini
2016-07-05  5:50     ` Wanpeng Li
2016-07-05 10:50       ` Paolo Bonzini
2016-06-29  3:17   ` Xiao Guangrong
2016-06-29  8:18     ` Paolo Bonzini
2016-06-30  7:18       ` Xiao Guangrong
2016-06-28  4:32 ` [PATCH 4/5] mmu: remove is_present_gpte() Bandan Das
2016-06-28  4:32 ` [PATCH 5/5] nvmx: advertise support for ept execute only Bandan Das

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1467088360-10186-3-git-send-email-bsd@redhat.com \
    --to=bsd@redhat.com \
    --cc=guangrong.xiao@linux.intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox