kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Liang Li <liang.z.li@intel.com>
To: qemu-devel@nongnu.org
Cc: mst@redhat.com, pbonzini@redhat.com, quintela@redhat.com,
	amit.shah@redhat.com, kvm@vger.kernel.org, dgilbert@redhat.com,
	thuth@redhat.com, Liang Li <liang.z.li@intel.com>
Subject: [QEMU v2 1/9] virtio-balloon: Remove needless precompiled directive
Date: Fri, 15 Jul 2016 10:47:21 +0800	[thread overview]
Message-ID: <1468550849-22172-2-git-send-email-liang.z.li@intel.com> (raw)
In-Reply-To: <1468550849-22172-1-git-send-email-liang.z.li@intel.com>

Since there in wrapper around madvise(), the virtio-balloon
code is able to work without the precompiled directive, the
directive can be removed.

Signed-off-by: Liang Li <liang.z.li@intel.com>
Suggested-by: Thomas Huth <thuth@redhat.com>
---
 hw/virtio/virtio-balloon.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c
index 1a22e6d..62931b3 100644
--- a/hw/virtio/virtio-balloon.c
+++ b/hw/virtio/virtio-balloon.c
@@ -34,13 +34,11 @@
 
 static void balloon_page(void *addr, int deflate)
 {
-#if defined(__linux__)
     if (!qemu_balloon_is_inhibited() && (!kvm_enabled() ||
                                          kvm_has_sync_mmu())) {
         qemu_madvise(addr, BALLOON_PAGE_SIZE,
                 deflate ? QEMU_MADV_WILLNEED : QEMU_MADV_DONTNEED);
     }
-#endif
 }
 
 static const char *balloon_stat_names[] = {
-- 
1.9.1


  reply	other threads:[~2016-07-15  2:55 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-15  2:47 [QEMU v2 0/9] Fast (de)inflating & fast live migration Liang Li
2016-07-15  2:47 ` Liang Li [this message]
2016-08-01 10:42   ` [QEMU v2 1/9] virtio-balloon: Remove needless precompiled directive Dr. David Alan Gilbert
2016-08-01 23:48     ` Li, Liang Z
2016-07-15  2:47 ` [QEMU v2 2/9] virtio-balloon: update linux head file Liang Li
2016-07-15  2:47 ` [QEMU v2 3/9] virtio-balloon: speed up inflating & deflating process Liang Li
2016-07-15  2:47 ` [QEMU v2 4/9] virtio-balloon: update linux head file for new feature Liang Li
2016-07-15  2:47 ` [QEMU v2 5/9] balloon: get free page info from guest Liang Li
2016-07-15  2:47 ` [QEMU v2 6/9] balloon: migrate vq elem to destination Liang Li
2016-07-15  2:47 ` [QEMU v2 7/9] bitmap: Add a new bitmap_move function Liang Li
2016-08-01 11:25   ` Dr. David Alan Gilbert
2016-07-15  2:47 ` [QEMU v2 8/9] kvm: Add two new arch specific functions Liang Li
2016-07-15  2:47 ` [QEMU v2 9/9] migration: skip free pages during live migration Liang Li
2016-07-21  8:10 ` [QEMU v2 0/9] Fast (de)inflating & fast " Li, Liang Z

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1468550849-22172-2-git-send-email-liang.z.li@intel.com \
    --to=liang.z.li@intel.com \
    --cc=amit.shah@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).