From: Suraj Jitindar Singh <sjitindarsingh@gmail.com>
To: kvm@vger.kernel.org
Cc: sjitindarsingh@gmail.com, pbonzini@redhat.com,
rkrcmar@redhat.com, drjones@redhat.com
Subject: [kvm-unit-tests RFC] Add ability to specify groups which won't be run by default
Date: Thu, 4 Aug 2016 11:58:27 +1000 [thread overview]
Message-ID: <1470275907-14780-1-git-send-email-sjitindarsingh@gmail.com> (raw)
Hi,
I'm looking at adding a powerpc test to kvm-unit-tests which has a high
potential of bringing down the host.
Thus I would like to be able to specify that it not be run by default when
all tests are being run, that is the user has to specifically run that test
on its own to ensure that they are sure that they want to run it.
The way I was thinking of doing this is by having some prefix for the
groups parameter in the unittests.cfg file, for example an underscore,
which specifies that this test group not be run when no groups parameter is
passed to run_tests.sh (i.e. all tests are being run). That is the user
will have to specifically specify that individual test group at invocation
to have it run.
Would you be open to having me add this to the generic test infrastructure?
I am open to comments or any other way you would prefer this be done. This
just seemed like the easiest option to me.
Example of patch below using underscore prefix as condition.
---
scripts/runtime.bash | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/scripts/runtime.bash b/scripts/runtime.bash
index 0503cf0..fbd415c 100644
--- a/scripts/runtime.bash
+++ b/scripts/runtime.bash
@@ -52,6 +52,12 @@ function run()
return
fi
+ if grep -q "^_" <<<$groups && ( [ -z "$only_group" ] || ( [ -n \
+ "$only_group" ] && ! grep -qw "$only_group" \
+ <<<$groups) ); then
+ return;
+ fi
+
if [ -n "$arch" ] && [ "$arch" != "$ARCH" ]; then
echo "`SKIP` $1 ($arch only)"
return 2
--
2.5.5
next reply other threads:[~2016-08-04 2:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-04 1:58 Suraj Jitindar Singh [this message]
2016-08-04 6:29 ` [kvm-unit-tests RFC] Add ability to specify groups which won't be run by default Andrew Jones
2016-08-04 12:35 ` Paolo Bonzini
2016-08-05 7:33 ` Suraj Jitindar Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470275907-14780-1-git-send-email-sjitindarsingh@gmail.com \
--to=sjitindarsingh@gmail.com \
--cc=drjones@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).