kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: kvm@vger.kernel.org
Cc: drjones@redhat.com, pbonzini@redhat.com, rkrcmar@redhat.com,
	peterx@redhat.com
Subject: [kvm-unit-tests PATCH v2 2/2] x86: apic: add LVT timer test
Date: Wed, 21 Sep 2016 13:09:42 +0800	[thread overview]
Message-ID: <1474434582-21431-3-git-send-email-peterx@redhat.com> (raw)
In-Reply-To: <1474434582-21431-1-git-send-email-peterx@redhat.com>

This is fairly basic, and guest codes are rarely changed. However it
might be something good to have to let APIC tests more complete.

Signed-off-by: Peter Xu <peterx@redhat.com>
---
 x86/apic.c        | 43 +++++++++++++++++++++++++++++++++++++++++++
 x86/unittests.cfg |  1 +
 2 files changed, 44 insertions(+)

diff --git a/x86/apic.c b/x86/apic.c
index 3a30f0f..4dc7a7b 100644
--- a/x86/apic.c
+++ b/x86/apic.c
@@ -351,6 +351,48 @@ static void test_multiple_nmi(void)
     report("multiple nmi", ok);
 }
 
+static volatile int lvtt_counter = 0;
+
+static void lvtt_handler(isr_regs_t *regs)
+{
+    lvtt_counter++;
+    eoi();
+}
+
+static void test_apic_timer_one_shot(void)
+{
+    uint64_t tsc1, tsc2;
+    static const uint32_t interval = 0x10000;
+
+#define APIC_LVT_TIMER_VECTOR    (0xee)
+#define APIC_LVT_TIMER_ONE_SHOT  (0)
+
+    handle_irq(APIC_LVT_TIMER_VECTOR, lvtt_handler);
+    irq_enable();
+
+    /* One shot mode */
+    apic_write(APIC_LVTT, APIC_LVT_TIMER_ONE_SHOT |
+               APIC_LVT_TIMER_VECTOR);
+    /* Divider == 1 */
+    apic_write(APIC_TDCR, 0x0000000b);
+
+    tsc1 = rdtsc();
+    /* Set "Initial Counter Register", which starts the timer */
+    apic_write(APIC_TMICT, interval);
+    while (!lvtt_counter);
+    tsc2 = rdtsc();
+
+    /*
+     * For LVT Timer clock, SDM vol 3 10.5.4 says it should be
+     * derived from processor's bus clock (IIUC which is the same
+     * as TSC), however QEMU seems to be using nanosecond. In all
+     * cases, the following should satisfy on all modern
+     * processors.
+     */
+    report("APIC LVT timer one shot", (lvtt_counter == 1) &&
+           (tsc2 - tsc1 >= interval));
+}
+
 int main()
 {
     setup_vm();
@@ -369,6 +411,7 @@ int main()
     test_sti_nmi();
     test_multiple_nmi();
 
+    test_apic_timer_one_shot();
     test_tsc_deadline_timer();
 
     return report_summary();
diff --git a/x86/unittests.cfg b/x86/unittests.cfg
index 4a1f74e..7242517 100644
--- a/x86/unittests.cfg
+++ b/x86/unittests.cfg
@@ -30,6 +30,7 @@ file = apic.flat
 smp = 2
 extra_params = -cpu qemu64,+x2apic,+tsc-deadline
 arch = x86_64
+timeout = 30
 
 [ioapic]
 file = ioapic.flat
-- 
2.7.4


  parent reply	other threads:[~2016-09-21  5:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-21  5:09 [kvm-unit-tests PATCH v2 0/2] x86: apic: add LVTT test Peter Xu
2016-09-21  5:09 ` [kvm-unit-tests PATCH v2 1/2] x86: apic: eoi() for deadline timer isr Peter Xu
2016-09-21  5:09 ` Peter Xu [this message]
2016-09-21  8:10   ` [kvm-unit-tests PATCH v2 2/2] x86: apic: add LVT timer test Andrew Jones
2016-09-21  8:12 ` [kvm-unit-tests PATCH v2 0/2] x86: apic: add LVTT test Andrew Jones
2016-09-22 22:41 ` Radim Krčmář

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1474434582-21431-3-git-send-email-peterx@redhat.com \
    --to=peterx@redhat.com \
    --cc=drjones@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=rkrcmar@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).