public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: kvm@vger.kernel.org
Cc: pbonzini@redhat.com, drjones@redhat.com, rkrcmar@redhat.com,
	peterx@redhat.com
Subject: [kvm-unit-tests PATCH 3/3] tests: don't call setup_idt() if with smp_init()
Date: Tue, 25 Oct 2016 17:00:30 +0800	[thread overview]
Message-ID: <1477386030-13955-4-git-send-email-peterx@redhat.com> (raw)
In-Reply-To: <1477386030-13955-1-git-send-email-peterx@redhat.com>

smp_init() will setup idt as default. No need to call it twice.

Signed-off-by: Peter Xu <peterx@redhat.com>
---
 x86/apic.c                | 1 -
 x86/hyperv_stimer.c       | 1 -
 x86/hyperv_synic.c        | 1 -
 x86/ioapic.c              | 1 -
 x86/tscdeadline_latency.c | 1 -
 5 files changed, 5 deletions(-)

diff --git a/x86/apic.c b/x86/apic.c
index fefb584..eff9a11 100644
--- a/x86/apic.c
+++ b/x86/apic.c
@@ -393,7 +393,6 @@ int main()
 {
     setup_vm();
     smp_init();
-    setup_idt();
 
     test_lapic_existence();
 
diff --git a/x86/hyperv_stimer.c b/x86/hyperv_stimer.c
index 6382938..5292523 100644
--- a/x86/hyperv_stimer.c
+++ b/x86/hyperv_stimer.c
@@ -330,7 +330,6 @@ static void stimer_test_all(void)
 
     setup_vm();
     smp_init();
-    setup_idt();
     enable_apic();
 
     handle_irq(SINT1_VEC, stimer_isr);
diff --git a/x86/hyperv_synic.c b/x86/hyperv_synic.c
index 3f98c42..74bbd58 100644
--- a/x86/hyperv_synic.c
+++ b/x86/hyperv_synic.c
@@ -154,7 +154,6 @@ int main(int ac, char **av)
 
         setup_vm();
         smp_init();
-        setup_idt();
         enable_apic();
 
         synic_prepare_sint_vecs();
diff --git a/x86/ioapic.c b/x86/ioapic.c
index a554e43..314c9bb 100644
--- a/x86/ioapic.c
+++ b/x86/ioapic.c
@@ -398,7 +398,6 @@ int main(void)
 {
 	setup_vm();
 	smp_init();
-	setup_idt();
 
 	mask_pic_interrupts();
 
diff --git a/x86/tscdeadline_latency.c b/x86/tscdeadline_latency.c
index 0592802..0617a1b 100644
--- a/x86/tscdeadline_latency.c
+++ b/x86/tscdeadline_latency.c
@@ -106,7 +106,6 @@ int main(int argc, char **argv)
 
     setup_vm();
     smp_init();
-    setup_idt();
 
     test_lapic_existence();
 
-- 
2.7.4


  parent reply	other threads:[~2016-10-25  9:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-25  9:00 [kvm-unit-tests PATCH 0/3] check multiple init for vm/smp Peter Xu
2016-10-25  9:00 ` [kvm-unit-tests PATCH 1/3] x86: vm: add assert to avoid multiple vm init Peter Xu
2016-10-25 12:32   ` Andrew Jones
2016-10-25  9:00 ` [kvm-unit-tests PATCH 2/3] x86: smp: assert to avoid multiple init of smp Peter Xu
2016-10-25  9:00 ` Peter Xu [this message]
2016-10-25  9:53   ` [kvm-unit-tests PATCH 3/3] tests: don't call setup_idt() if with smp_init() Andrew Jones
2016-10-25 10:16     ` Andrew Jones
2016-10-25 16:00   ` Paolo Bonzini
2016-10-25 10:12 ` [kvm-unit-tests PATCH 0/3] check multiple init for vm/smp Andrew Jones
2016-10-25 11:56   ` Peter Xu
2016-10-25 16:00     ` Paolo Bonzini
2016-10-26  2:53       ` Peter Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1477386030-13955-4-git-send-email-peterx@redhat.com \
    --to=peterx@redhat.com \
    --cc=drjones@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=rkrcmar@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox